More missing webhooks

Author: dprince

cmd/main.go

@@ -41,6 +41,7 @@ import (
 	clientcontroller "github.com/openstack-k8s-operators/openstack-operator/internal/controller/client"
 	corecontroller "github.com/openstack-k8s-operators/openstack-operator/internal/controller/core"
 	dataplanecontroller "github.com/openstack-k8s-operators/openstack-operator/internal/controller/dataplane"
+	webhookclientv1beta1 "github.com/openstack-k8s-operators/openstack-operator/internal/webhook/client/v1beta1"
 	webhookcorev1beta1 "github.com/openstack-k8s-operators/openstack-operator/internal/webhook/core/v1beta1"
 	webhookdataplanev1beta1 "github.com/openstack-k8s-operators/openstack-operator/internal/webhook/dataplane/v1beta1"
 
@@ -382,10 +383,25 @@ func main() {
 			os.Exit(1)
 		}
 		// nolint:goconst
+		if err := webhookclientv1beta1.SetupOpenStackClientWebhookWithManager(mgr); err != nil {
+			setupLog.Error(err, "unable to create webhook", "webhook", "OpenStackClient")
+			os.Exit(1)
+		}
+		// nolint:goconst
 		if err := webhookdataplanev1beta1.SetupOpenStackDataPlaneNodeSetWebhookWithManager(mgr); err != nil {
 			setupLog.Error(err, "unable to create webhook", "webhook", "OpenStackDataPlaneNodeSet")
 			os.Exit(1)
 		}
+		// nolint:goconst
+		if err := webhookdataplanev1beta1.SetupOpenStackDataPlaneDeploymentWebhookWithManager(mgr); err != nil {
+			setupLog.Error(err, "unable to create webhook", "webhook", "OpenStackDataPlaneDeployment")
+			os.Exit(1)
+		}
+		// nolint:goconst
+		if err := webhookdataplanev1beta1.SetupOpenStackDataPlaneServiceWebhookWithManager(mgr); err != nil {
+			setupLog.Error(err, "unable to create webhook", "webhook", "OpenStackDataPlaneService")
+			os.Exit(1)
+		}
 	}
 	// +kubebuilder:scaffold:builder
 

config/webhook/manifests.yaml

@@ -4,6 +4,26 @@ kind: MutatingWebhookConfiguration
 metadata:
   name: mutating-webhook-configuration
 webhooks:
+- admissionReviewVersions:
+  - v1
+  clientConfig:
+    service:
+      name: webhook-service
+      namespace: system
+      path: /mutate-client-openstack-org-v1beta1-openstackclient
+  failurePolicy: Fail
+  name: mopenstackclient-v1beta1.kb.io
+  rules:
+  - apiGroups:
+    - client.openstack.org
+    apiVersions:
+    - v1beta1
+    operations:
+    - CREATE
+    - UPDATE
+    resources:
+    - openstackclients
+  sideEffects: None
 - admissionReviewVersions:
   - v1
   clientConfig:
@@ -44,6 +64,26 @@ webhooks:
     resources:
     - openstackversions
   sideEffects: None
+- admissionReviewVersions:
+  - v1
+  clientConfig:
+    service:
+      name: webhook-service
+      namespace: system
+      path: /mutate-dataplane-openstack-org-v1beta1-openstackdataplanedeployment
+  failurePolicy: Fail
+  name: mopenstackdataplanedeployment-v1beta1.kb.io
+  rules:
+  - apiGroups:
+    - dataplane.openstack.org
+    apiVersions:
+    - v1beta1
+    operations:
+    - CREATE
+    - UPDATE
+    resources:
+    - openstackdataplanedeployments
+  sideEffects: None
 - admissionReviewVersions:
   - v1
   clientConfig:
@@ -64,6 +104,26 @@ webhooks:
     resources:
     - openstackdataplanenodesets
   sideEffects: None
+- admissionReviewVersions:
+  - v1
+  clientConfig:
+    service:
+      name: webhook-service
+      namespace: system
+      path: /mutate-dataplane-openstack-org-v1beta1-openstackdataplaneservice
+  failurePolicy: Fail
+  name: mopenstackdataplaneservice-v1beta1.kb.io
+  rules:
+  - apiGroups:
+    - dataplane.openstack.org
+    apiVersions:
+    - v1beta1
+    operations:
+    - CREATE
+    - UPDATE
+    resources:
+    - openstackdataplaneservices
+  sideEffects: None
 - admissionReviewVersions:
   - v1
   clientConfig:
@@ -130,6 +190,26 @@ kind: ValidatingWebhookConfiguration
 metadata:
   name: validating-webhook-configuration
 webhooks:
+- admissionReviewVersions:
+  - v1
+  clientConfig:
+    service:
+      name: webhook-service
+      namespace: system
+      path: /validate-client-openstack-org-v1beta1-openstackclient
+  failurePolicy: Fail
+  name: vopenstackclient-v1beta1.kb.io
+  rules:
+  - apiGroups:
+    - client.openstack.org
+    apiVersions:
+    - v1beta1
+    operations:
+    - CREATE
+    - UPDATE
+    resources:
+    - openstackclients
+  sideEffects: None
 - admissionReviewVersions:
   - v1
   clientConfig:
@@ -170,6 +250,26 @@ webhooks:
     resources:
     - openstackversions
   sideEffects: None
+- admissionReviewVersions:
+  - v1
+  clientConfig:
+    service:
+      name: webhook-service
+      namespace: system
+      path: /validate-dataplane-openstack-org-v1beta1-openstackdataplanedeployment
+  failurePolicy: Fail
+  name: vopenstackdataplanedeployment-v1beta1.kb.io
+  rules:
+  - apiGroups:
+    - dataplane.openstack.org
+    apiVersions:
+    - v1beta1
+    operations:
+    - CREATE
+    - UPDATE
+    resources:
+    - openstackdataplanedeployments
+  sideEffects: None
 - admissionReviewVersions:
   - v1
   clientConfig:
@@ -190,6 +290,26 @@ webhooks:
     resources:
     - openstackdataplanenodesets
   sideEffects: None
+- admissionReviewVersions:
+  - v1
+  clientConfig:
+    service:
+      name: webhook-service
+      namespace: system
+      path: /validate-dataplane-openstack-org-v1beta1-openstackdataplaneservice
+  failurePolicy: Fail
+  name: vopenstackdataplaneservice-v1beta1.kb.io
+  rules:
+  - apiGroups:
+    - dataplane.openstack.org
+    apiVersions:
+    - v1beta1
+    operations:
+    - CREATE
+    - UPDATE
+    resources:
+    - openstackdataplaneservices
+  sideEffects: None
 - admissionReviewVersions:
   - v1
   clientConfig:

internal/webhook/client/v1beta1/openstackclient_webhook.go

@@ -65,7 +65,8 @@ func (d *OpenStackClientCustomDefaulter) Default(_ context.Context, obj runtime.
 	}
 	openstackclientlog.Info("Defaulting for OpenStackClient", "name", openstackclient.GetName())
 
-	// TODO(user): fill in your defaulting logic.
+	// Call the Default method on the OpenStackClient type
+	openstackclient.Default()
 
 	return nil
 }
@@ -94,9 +95,8 @@ func (v *OpenStackClientCustomValidator) ValidateCreate(_ context.Context, obj r
 	}
 	openstackclientlog.Info("Validation for OpenStackClient upon creation", "name", openstackclient.GetName())
 
-	// TODO(user): fill in your validation logic upon object creation.
-
-	return nil, nil
+	// Call the ValidateCreate method on the OpenStackClient type
+	return openstackclient.ValidateCreate()
 }
 
 // ValidateUpdate implements webhook.CustomValidator so a webhook will be registered for the type OpenStackClient.
@@ -107,9 +107,8 @@ func (v *OpenStackClientCustomValidator) ValidateUpdate(_ context.Context, oldOb
 	}
 	openstackclientlog.Info("Validation for OpenStackClient upon update", "name", openstackclient.GetName())
 
-	// TODO(user): fill in your validation logic upon object update.
-
-	return nil, nil
+	// Call the ValidateUpdate method on the OpenStackClient type
+	return openstackclient.ValidateUpdate(oldObj)
 }
 
 // ValidateDelete implements webhook.CustomValidator so a webhook will be registered for the type OpenStackClient.
@@ -120,7 +119,6 @@ func (v *OpenStackClientCustomValidator) ValidateDelete(ctx context.Context, obj
 	}
 	openstackclientlog.Info("Validation for OpenStackClient upon deletion", "name", openstackclient.GetName())
 
-	// TODO(user): fill in your validation logic upon object deletion.
-
-	return nil, nil
+	// Call the ValidateDelete method on the OpenStackClient type
+	return openstackclient.ValidateDelete()
 }

internal/webhook/dataplane/v1beta1/openstackdataplanedeployment_webhook.go

@@ -65,7 +65,8 @@ func (d *OpenStackDataPlaneDeploymentCustomDefaulter) Default(_ context.Context,
 	}
 	openstackdataplanedeploymentlog.Info("Defaulting for OpenStackDataPlaneDeployment", "name", openstackdataplanedeployment.GetName())
 
-	// TODO(user): fill in your defaulting logic.
+	// Call the Default method on the OpenStackDataPlaneDeployment type
+	openstackdataplanedeployment.Default()
 
 	return nil
 }
@@ -94,9 +95,8 @@ func (v *OpenStackDataPlaneDeploymentCustomValidator) ValidateCreate(_ context.C
 	}
 	openstackdataplanedeploymentlog.Info("Validation for OpenStackDataPlaneDeployment upon creation", "name", openstackdataplanedeployment.GetName())
 
-	// TODO(user): fill in your validation logic upon object creation.
-
-	return nil, nil
+	// Call the ValidateCreate method on the OpenStackDataPlaneDeployment type
+	return openstackdataplanedeployment.ValidateCreate()
 }
 
 // ValidateUpdate implements webhook.CustomValidator so a webhook will be registered for the type OpenStackDataPlaneDeployment.
@@ -107,9 +107,8 @@ func (v *OpenStackDataPlaneDeploymentCustomValidator) ValidateUpdate(_ context.C
 	}
 	openstackdataplanedeploymentlog.Info("Validation for OpenStackDataPlaneDeployment upon update", "name", openstackdataplanedeployment.GetName())
 
-	// TODO(user): fill in your validation logic upon object update.
-
-	return nil, nil
+	// Call the ValidateUpdate method on the OpenStackDataPlaneDeployment type
+	return openstackdataplanedeployment.ValidateUpdate(oldObj)
 }
 
 // ValidateDelete implements webhook.CustomValidator so a webhook will be registered for the type OpenStackDataPlaneDeployment.
@@ -120,7 +119,6 @@ func (v *OpenStackDataPlaneDeploymentCustomValidator) ValidateDelete(ctx context
 	}
 	openstackdataplanedeploymentlog.Info("Validation for OpenStackDataPlaneDeployment upon deletion", "name", openstackdataplanedeployment.GetName())
 
-	// TODO(user): fill in your validation logic upon object deletion.
-
-	return nil, nil
+	// Call the ValidateDelete method on the OpenStackDataPlaneDeployment type
+	return openstackdataplanedeployment.ValidateDelete()
 }

internal/webhook/dataplane/v1beta1/openstackdataplaneservice_webhook.go

@@ -65,7 +65,8 @@ func (d *OpenStackDataPlaneServiceCustomDefaulter) Default(_ context.Context, ob
 	}
 	openstackdataplaneservicelog.Info("Defaulting for OpenStackDataPlaneService", "name", openstackdataplaneservice.GetName())
 
-	// TODO(user): fill in your defaulting logic.
+	// Call the Default method on the OpenStackDataPlaneService type
+	openstackdataplaneservice.Default()
 
 	return nil
 }
@@ -94,9 +95,8 @@ func (v *OpenStackDataPlaneServiceCustomValidator) ValidateCreate(_ context.Cont
 	}
 	openstackdataplaneservicelog.Info("Validation for OpenStackDataPlaneService upon creation", "name", openstackdataplaneservice.GetName())
 
-	// TODO(user): fill in your validation logic upon object creation.
-
-	return nil, nil
+	// Call the ValidateCreate method on the OpenStackDataPlaneService type
+	return openstackdataplaneservice.ValidateCreate()
 }
 
 // ValidateUpdate implements webhook.CustomValidator so a webhook will be registered for the type OpenStackDataPlaneService.
@@ -107,9 +107,8 @@ func (v *OpenStackDataPlaneServiceCustomValidator) ValidateUpdate(_ context.Cont
 	}
 	openstackdataplaneservicelog.Info("Validation for OpenStackDataPlaneService upon update", "name", openstackdataplaneservice.GetName())
 
-	// TODO(user): fill in your validation logic upon object update.
-
-	return nil, nil
+	// Call the ValidateUpdate method on the OpenStackDataPlaneService type
+	return openstackdataplaneservice.ValidateUpdate(oldObj)
 }
 
 // ValidateDelete implements webhook.CustomValidator so a webhook will be registered for the type OpenStackDataPlaneService.
@@ -120,7 +119,6 @@ func (v *OpenStackDataPlaneServiceCustomValidator) ValidateDelete(ctx context.Co
 	}
 	openstackdataplaneservicelog.Info("Validation for OpenStackDataPlaneService upon deletion", "name", openstackdataplaneservice.GetName())
 
-	// TODO(user): fill in your validation logic upon object deletion.
-
-	return nil, nil
+	// Call the ValidateDelete method on the OpenStackDataPlaneService type
+	return openstackdataplaneservice.ValidateDelete()
 }