Fix misinterpretation of function arguments with parameters (#45)#96
Fix misinterpretation of function arguments with parameters (#45)#96dyrpsf wants to merge 2 commits into
Conversation
draeger
left a comment
There was a problem hiding this comment.
This looks good: The only comment I have is that we now have two parts of the code with nearly identical and comparably complex code. If further improvements or corrections are necessary, adjustments will need to be made to the positions. If it were possible to unify both methods by performing the pre- and postprocessing steps in sub-methods, maintenance could be simplified, and duplication errors could be reduced.
|
@draeger Thanks for the review and the suggestion! You’re right, |
|
Hi @draeger, |
This PR fixes issue #45: when a FunctionDefinition has bvars with the same ids as
global parameters, SBSCL used the parameter values instead of the argument values
inside the function body.
The fix:
evaluating the function body in functionDouble(...) and functionBoolean(...).
With this change, identifiers inside a function body correctly refer to the function
arguments, even if parameters with the same ids exist in the model.