Abilities API: Stop HTML-escaping the ability name in WP_Error messages

Ability names are pattern-validated at registration, so `esc_html()` on them is always a no-op. Drop it from the `WP_Error` messages, which are commonly serialized to JSON where the escaping would be incorrect.

Follow-up to [62398].
See #64311.



git-svn-id: https://develop.svn.wordpress.org/trunk@62401 602fd350-edb4-49c9-b593-d223f7449a82

Author: gziolo

src/wp-includes/abilities-api/class-wp-ability.php

@@ -561,7 +561,7 @@ protected function invoke_callback( callable $callback, $input = null ) {
 				sprintf(
 					/* translators: 1: Ability name, 2: Exception message. */
 					__( 'Ability "%1$s" callback threw an exception: %2$s' ),
-					esc_html( $this->name ),
+					$this->name,
 					esc_html( $e->getMessage() )
 				)
 			);
@@ -590,7 +590,7 @@ public function check_permissions( $input = null ) {
 			return new WP_Error(
 				'ability_invalid_permission_callback',
 				/* translators: %s ability name. */
-				sprintf( __( 'Ability "%s" does not have a valid permission callback.' ), esc_html( $this->name ) )
+				sprintf( __( 'Ability "%s" does not have a valid permission callback.' ), $this->name )
 			);
 		}
 
@@ -638,7 +638,7 @@ protected function do_execute( $input = null ) {
 			$result = new WP_Error(
 				'ability_invalid_execute_callback',
 				/* translators: %s ability name. */
-				sprintf( __( 'Ability "%s" does not have a valid execute callback.' ), esc_html( $this->name ) )
+				sprintf( __( 'Ability "%s" does not have a valid execute callback.' ), $this->name )
 			);
 		} else {
 			$result = $this->invoke_callback( $this->execute_callback, $input );
@@ -783,7 +783,7 @@ public function execute( $input = null ) {
 			return new WP_Error(
 				'ability_invalid_permissions',
 				/* translators: %s ability name. */
-				sprintf( __( 'Ability "%s" does not have necessary permission.' ), esc_html( $this->name ) )
+				sprintf( __( 'Ability "%s" does not have necessary permission.' ), $this->name )
 			);
 		}