Design: Rolling Plugin Upgrade — POC findings, risks & counterargument#14
Open
danielgerlag wants to merge 5 commits into
Open
Design: Rolling Plugin Upgrade — POC findings, risks & counterargument#14danielgerlag wants to merge 5 commits into
danielgerlag wants to merge 5 commits into
Conversation
…posal - Document POC findings from atomic-comp branch (validates rolling migration via update_source/update_reaction) - Add Library Unloading Risk Analysis (segfault risks from dlclose) - Add Argument Against Hot Upgrades section - Add caveat callouts to contradicted claims in original design Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Proposes a simpler approach: browse/download plugins via VS Code extension or CLI, stage them on disk, and apply on next restart. Includes UI mockup, CLI commands, registry sketch, and startup promotion logic. Restores Open Issues section with two new questions. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extends the dual-load rolling plugin upgrade design document with:
atomic-compbranch POC, including what was validated, key divergences from the design, and production gaps.mem::forgettodlclose-on-drop (background tasks, escaped trait objects, thread-locals, field reorder fragility).Key Question for Discussion
Should we pursue hot plugin upgrades at all, or ship a polished restart-based upgrade command instead?