Skip to content

Resolve remaining MySQL docs review thread inconsistencies#218

Merged
danielgerlag merged 3 commits into
mysqlfrom
copilot/fix-comments-review-thread-217
May 22, 2026
Merged

Resolve remaining MySQL docs review thread inconsistencies#218
danielgerlag merged 3 commits into
mysqlfrom
copilot/fix-comments-review-thread-217

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 21, 2026

This updates the MySQL source/bootstrap documentation to resolve the review-thread mismatches between documented requirements and actual configuration behavior. The edits focus on correctness of version prerequisites, verification SQL, and bootstrap-provider field semantics.

  • MySQL source doc corrections

    • Raised documented minimum to MySQL 8.0+ (to align with binlog_row_metadata = FULL usage).
    • Replaced invalid verification SQL with valid primary-side binlog status command.
    • Reworded the env-var substitution sentence for clarity.
  • MySQL bootstrap provider doc alignment

    • Removed conflicting field-level bootstrap config guidance.
    • Documented bootstrap provider as kind-only for MySQL (bootstrapProvider.kind), with connection/table scope inherited from the source (host, database, tables, tableKeys).
    • Updated prerequisite wording to reflect source-owned table configuration.
sources:
  - kind: mysql
    host: ${MYSQL_HOST:-localhost}
    database: ${MYSQL_DATABASE:-mydb}
    tables: [orders, customers]
    bootstrapProvider:
      kind: mysql
SHOW MASTER STATUS;

Copilot AI requested review from Copilot and removed request for Copilot May 21, 2026 23:45
Copilot AI requested review from Copilot and removed request for Copilot May 21, 2026 23:49
Copilot AI changed the title [WIP] Fix code issues from review comments in PR 217 Resolve remaining MySQL docs review thread inconsistencies May 21, 2026
Copilot AI requested a review from danielgerlag May 21, 2026 23:50
@danielgerlag
Copy link
Copy Markdown
Contributor

@copilot i think this PR is targetting the wrong branch?

Copy link
Copy Markdown
Contributor Author

Copilot AI commented May 22, 2026

@copilot i think this PR is targetting the wrong branch?

You’re right — this is currently targeting main. I can’t change the PR base from this environment; please retarget the PR to the intended branch, and I’ll continue from there.

@danielgerlag danielgerlag changed the base branch from main to mysql May 22, 2026 01:19
@danielgerlag
Copy link
Copy Markdown
Contributor

@copilot i retargetted it, please continue

Copy link
Copy Markdown
Contributor Author

Copilot AI commented May 22, 2026

@copilot i retargetted it, please continue

I checked it after retargeting and there are no additional code changes needed from my side right now. The docs fixes are in ffe9726, and the latest mysql workflow runs are passing.

@danielgerlag danielgerlag marked this pull request as ready for review May 22, 2026 01:31
@danielgerlag danielgerlag requested a review from a team as a code owner May 22, 2026 01:31
@danielgerlag danielgerlag merged commit 0af0ecc into mysql May 22, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants