Skip to content

fix: offset new tables and areas to prevent overlapping placement #951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
VeerShah41 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: offset new tables and areas to prevent overlapping placement #951

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 16 additions & 13 deletions src/context/AreasContext.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,19 +23,22 @@ export default function AreasContextProvider({ children }) {
} else {
const width = 200;
const height = 200;
setAreas((prev) => [
...prev,
{
id: prev.length,
name: `area_${prev.length}`,
x: transform.pan.x - width / 2,
y: transform.pan.y - height / 2,
width,
height,
color: defaultBlue,
locked: false,
},
]);
setAreas((prev) => {
const offset = prev.length * 20;
return [
...prev,
{
id: prev.length,
name: `area_${prev.length}`,
x: transform.pan.x - width / 2 + offset,
y: transform.pan.y - height / 2 + offset,
width,
height,
color: defaultBlue,
locked: false,
},
];
});
}
if (addToHistory) {
setUndoStack((prev) => [
Expand Down
5 changes: 3 additions & 2 deletions src/context/DiagramContext.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,12 @@ export default function DiagramContextProvider({ children }) {

const addTable = (data, addToHistory = true) => {
const id = nanoid();
const offset = tables.length * 20;
const newTable = {
id,
name: `table_${id}`,
x: transform.pan.x,
y: transform.pan.y,
x: transform.pan.x + offset,
y: transform.pan.y + offset,
locked: false,
fields: [
{
Expand Down
Loading