fix: add Bengali translations and make database descriptions translatable#977
Open
VISHNU7KASIREDDY wants to merge 2 commits intodrawdb-io:mainfrom
Open
fix: add Bengali translations and make database descriptions translatable#977VISHNU7KASIREDDY wants to merge 2 commits intodrawdb-io:mainfrom
VISHNU7KASIREDDY wants to merge 2 commits intodrawdb-io:mainfrom
Conversation
- Add translation keys for all database names (MySQL, PostgreSQL, SQLite, MariaDB, MSSQL, Oracle SQL) - Update Workspace.jsx to use i18n translation function for database names - Ensure database names are translatable across all 48 supported languages Fixes drawdb-io#799
- Add translation keys for all database descriptions in en.js - Add Bengali translations for database names and descriptions in bn.js - Update databases.js to use i18n.t() for descriptions - Update Workspace.jsx to render translated descriptions for all databases - Revert unnecessary package-lock.json changes Fixes drawdb-io#799
|
@VISHNU7KASIREDDY is attempting to deploy a commit to the dottle's projects Team on Vercel. A member of the Team first needs to authorize it. |
Author
|
added bengali translations for the database type descriptions that were missing. also filled in the missing i18n keys for a few fields. let me know if anything looks off. |
Author
|
Hi @OviSaba, could you please review and merge this when you have time? Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #799 — database names and descriptions were not translatable, causing them to always appear in English regardless of the user's selected language.
Changes
src/data/databases.js— Wrap database descriptions ini18n.t()calls so they can be translatedsrc/components/Workspace.jsx— Update database name and description rendering to use translated strings viat()src/i18n/locales/en.js— Add translation keys for database names and descriptions in Englishsrc/i18n/locales/bn.js— Add complete Bengali translations for all database names and descriptionsTesting
The database selection screen now correctly renders translated database names and descriptions when the app language is set to Bengali (or any other language that provides these keys).