feat: Support @apollo/client@^4#86
Merged
Merged
Conversation
Signed-off-by: Matthew Peveler <matt.peveler@gmail.com>
Signed-off-by: Matthew Peveler <matt.peveler@gmail.com>
Signed-off-by: Matthew Peveler <matt.peveler@gmail.com>
MasterOdin
force-pushed
the
apollo-4-2
branch
from
76ab02c to
25cd637
Compare
MasterOdin
force-pushed
the
apollo-4-2
branch
from
3ca4cdc to
d3c98a5
Compare
MasterOdin
force-pushed
the
apollo-4-2
branch
from
2dddc8d to
65d0225
Compare
Signed-off-by: Matthew Peveler <matt.peveler@gmail.com>
MasterOdin
commented
Dec 26, 2025
| node-version: ${{ matrix.node-version }} | ||
|
|
||
| - run: yarn --ignore-scripts | ||
| - run: yarn add --ignore-scripts --dev @apollo/client@4.0.0 graphql@16.0.0 rxjs@^7.3.0 |
Collaborator
Author
There was a problem hiding this comment.
7.3.0 is the peer dependency for @apollo/client, but it doesn't compile against cjs. Not really keen to try to figure out the lowest version, and not sure it really matters vs @apollo/client which is the real thing we build against.
This was referenced Dec 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #82
PR adds support for
@apollo/client@4to the library. This is similar to #85, though just utilizes the deprecated types only, which allows for a somewhat cleaner experience for folks on v3 without having to worry aboutskipLibChecktsconfig setting.However, we still move to using
es2016for compilation vses5, however, the same point still holds where:Add to this that the library only tests against 12.x, then this shouldn't affect anyone meaningfully that I think ti'd be fine to put this out as a point release.