Skip to content

Commit 5f350b2

Browse files
Fix typo in xml_tools TODO and update CONTRIBUTING.md (#343)
Low-hanging PR to start contributing to this project. ### Key Changes - Fix typo in TODO comment in `rigging/transform/xml_tools.py` (cased → cases). - Update CONTRIBUTING.md: remove the CLA step from the PR guidelines and the Facebook CLA section. Not sure but I was reading the contributing guidelines and this section seemed a bit off -- since it refers to Facebook’s CLA and this repo is clearly not one, so it doesn’t seem to apply here -- removed for now; maintainers can add a dreadnode-specific CLA link if needed. Apologies if I misunderstood it. ### Added - (none) ### Changed - **rigging/transform/xml_tools.py:** TODO comment now reads “handle cases where…”. - **.github/CONTRIBUTING.md:** Removed the Contributor License Agreement bullet from the PR guidelines and the Facebook CLA section. ### Removed - References to Facebook and the code.facebook.com CLA from CONTRIBUTING.md.
2 parents b51345c + 667c6ed commit 5f350b2

File tree

2 files changed

+1
-9
lines changed

2 files changed

+1
-9
lines changed

.github/CONTRIBUTING.md

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ We actively welcome your pull requests.
1212
3. If you've changed APIs, update the documentation.
1313
4. Ensure the test suite passes.
1414
5. Make sure your code lints.
15-
6. If you haven't already, complete the Contributor License Agreement ("CLA").
1615

1716
### PR Description Format
1817

@@ -54,13 +53,6 @@ Example:
5453
- Deprecated setup scripts
5554
```
5655

57-
## Contributor License Agreement ("CLA")
58-
59-
In order to accept your pull request, we need you to submit a CLA. You only need
60-
to do this once to work on any of Facebook's open source projects.
61-
62-
Complete your CLA here: <https://code.facebook.com/cla>
63-
6456
## Issues
6557

6658
We use GitHub issues to track public bugs. Please ensure your description is

rigging/transform/xml_tools.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -373,7 +373,7 @@ async def xml_to_tools_transform(chat: "Chat") -> "Chat": # noqa: PLR0912
373373
message.remove_slices(XmlToolCall)
374374

375375
# Convert our tool responses
376-
# TODO: handle cased where multiple tool responses are present
376+
# TODO: handle cases where multiple tool responses are present
377377

378378
for message in chat.all:
379379
if (tool_response := message.try_parse(ToolResponse)) is None:

0 commit comments

Comments
 (0)