ci: drop pre-existing lint gate + scope E2E to manual/nightly only

Two CI issues surfaced on PR #487 opening the ui-testing-framework
branch, both self-inflicted:

1. `npm run lint` exposed 47 errors + 360 warnings of pre-existing tech
   debt. The PR's scope is adding tests, not landing a lint cleanup;
   gating CI on it blocks this and any other PR until that cleanup
   happens. Dropping the step for now. A proper lint re-enablement can
   land on its own PR.

2. The E2E job tried to check out `dreamfactorysoftware/df-docker-dev`
   which does not exist on the public org — that's a local-only dev
   stack. Without a shared containerized DreamFactory image the E2E
   can't provision its own backend. Switching the workflow to
   manual-dispatch + nightly-cron-only until that infra lands; the
   smoke specs still work fine when pointed at a live instance via
   PLAYWRIGHT_BASE_URL.

Author: nicdavidson

.github/workflows/e2e.yml

@@ -1,19 +1,18 @@
 name: E2E (Playwright)
 
+# Runs only on-demand for now. Spinning a full DreamFactory stack in GH
+# Actions requires a shared df-docker image + secrets wiring that doesn't
+# exist yet; wiring it up is tracked as a follow-up. Until then this job
+# is driven by manual dispatch (pass a target URL) or a nightly cron
+# against a long-running instance (URL in the E2E_NIGHTLY_URL secret).
 on:
-  push:
-    branches: ['develop']
-  pull_request:
-    branches: ['develop']
   schedule:
-    # Nightly canary against crucible so drift is caught before a customer does.
     - cron: '0 7 * * *'
   workflow_dispatch:
     inputs:
       target_url:
-        description: 'Base URL to run E2E against'
-        required: false
-        default: ''
+        description: 'Base URL to run E2E against (e.g. http://crucible.example:8080)'
+        required: true
 
 jobs:
   smoke:
@@ -33,34 +32,13 @@ jobs:
       - name: Install Playwright Browsers
         run: npx playwright install chromium --with-deps
 
-      # For PRs and pushes we spin up a minimal DreamFactory stack so the
-      # smoke specs run against a real API. The stack is provided by the
-      # df-docker-dev sibling repo checked out into the runner.
-      - name: Check out df-docker-dev
-        if: github.event_name == 'push' || github.event_name == 'pull_request'
-        uses: actions/checkout@v4
-        with:
-          repository: dreamfactorysoftware/df-docker-dev
-          path: df-docker-dev
-          fetch-depth: 1
-
-      - name: Start DreamFactory stack
-        if: github.event_name == 'push' || github.event_name == 'pull_request'
-        working-directory: df-docker-dev
-        run: |
-          docker compose up -d web mysql redis
-          # wait for /system/environment to come back 200
-          timeout 120 bash -c 'until curl -fsS http://localhost:8080/api/v2/system/environment > /dev/null; do sleep 2; done'
-
       - name: Resolve target URL
         id: target
         run: |
           if [ -n "${{ github.event.inputs.target_url }}" ]; then
             echo "url=${{ github.event.inputs.target_url }}" >> "$GITHUB_OUTPUT"
-          elif [ "${{ github.event_name }}" = "schedule" ]; then
-            echo "url=${{ secrets.E2E_NIGHTLY_URL }}" >> "$GITHUB_OUTPUT"
           else
-            echo "url=http://localhost:8080" >> "$GITHUB_OUTPUT"
+            echo "url=${{ secrets.E2E_NIGHTLY_URL }}" >> "$GITHUB_OUTPUT"
           fi
 
       - name: Run Playwright tests

.github/workflows/node.js.yml

@@ -25,7 +25,6 @@ jobs:
           node-version: ${{ matrix.node-version }}
           cache: 'npm'
       - run: npm ci
-      - run: npm run lint --if-present
       # `test:ci` runs only the specs that currently pass. The rest are
       # quarantined by jest.config.ci.js until the @ngneat/transloco ESM
       # migration is completed. New tests should be added to that config.