DF-1301 #comment Do not cache full responses with error status codes

Lee Hicks · web-flow · commit 660d997cb55d · 2018-02-19T17:32:34.000-05:00
diff --git a/src/Services/Script.php b/src/Services/Script.php
@@ -315,7 +315,8 @@ protected function processRequest()
             $result = ResponseFactory::create($result);
         }
 
-        if ($cacheKey) {
+        $status = $result->getStatusCode();
+        if ($cacheKey && (($status >= 200) && ($status < 300))) { // do not cache error responses
             $this->addToCache($cacheKey, $result);
         }
 

Original file line number	Diff line number	Diff line change
`@@ -315,7 +315,8 @@ protected function processRequest()`
`315`	`315`	`$result = ResponseFactory::create($result);`
`316`	`316`	`}`
`317`	`317`
`318`		`- if ($cacheKey) {`
	`318`	`+ $status = $result->getStatusCode();`
	`319`	`+ if ($cacheKey && (($status >= 200) && ($status < 300))) { // do not cache error responses`
`319`	`320`	`$this->addToCache($cacheKey, $result);`
`320`	`321`	`}`
`321`	`322`