Fixed coverage comment script to avoid piped curl mocks in BATS tests.

Author: AlexSkrypnyk

.circleci/post-coverage-comment.sh

@@ -38,25 +38,27 @@ REPO_SLUG="${CIRCLE_PROJECT_USERNAME}/${CIRCLE_PROJECT_REPONAME}"
 
 MARKER="<!-- coverage-circleci -->"
 
-BODY="$(jq -n --arg body "**Code coverage (CircleCI)**
+BODY=$(jq -n --arg body "**Code coverage (CircleCI)**
 \`\`\`
 ${COVERAGE_CONTENT}
 \`\`\`
-${MARKER}" '{body: $body}')"
+${MARKER}" '{body: $body}')
 
 # Minimize previous coverage comments.
-EXISTING_IDS=$(curl -s \
+COMMENTS_JSON=$(curl -s \
   -H "Authorization: token ${GITHUB_TOKEN}" \
   -H "Accept: application/vnd.github.v3+json" \
-  "https://api.github.com/repos/${REPO_SLUG}/issues/${PR_NUMBER}/comments?per_page=100" |
-  jq -r '.[] | select(.body | contains("<!-- coverage-circleci -->")) | .node_id')
+  "https://api.github.com/repos/${REPO_SLUG}/issues/${PR_NUMBER}/comments?per_page=100")
+
+EXISTING_IDS=$(echo "${COMMENTS_JSON}" | jq -r '.[] | select(.body | contains("<!-- coverage-circleci -->")) | .node_id')
 
 for NODE_ID in ${EXISTING_IDS}; do
+  GRAPHQL_BODY=$(jq -n --arg id "${NODE_ID}" '{query: "mutation($id:ID!){minimizeComment(input:{subjectId:$id,classifier:OUTDATED}){minimizedComment{isMinimized}}}", variables: {id: $id}}')
   curl -s -X POST \
     -H "Authorization: bearer ${GITHUB_TOKEN}" \
     -H "Content-Type: application/json" \
     "https://api.github.com/graphql" \
-    -d "$(jq -n --arg id "${NODE_ID}" '{query: "mutation($id:ID!){minimizeComment(input:{subjectId:$id,classifier:OUTDATED}){minimizedComment{isMinimized}}}", variables: {id: $id}}')"
+    -d "${GRAPHQL_BODY}"
 done
 
 # Post new coverage comment.

.vortex/tests/bats/unit/post-coverage-comment.bats

@@ -74,9 +74,9 @@ load ../_helper.bash
 
   declare -a STEPS=(
     # GET existing comments - return empty array.
-    "@curl -s -H Authorization: token token12345 -H Accept: application/vnd.github.v3+json https://api.github.com/repos/myorg/myrepo/issues/123/comments?per_page=100 # []"
+    '@curl * # []'
     # POST new comment.
-    '@curl -s -X POST -H Authorization: token token12345 -H Accept: application/vnd.github.v3+json https://api.github.com/repos/myorg/myrepo/issues/123/comments * # {"id": 1}'
+    '@curl * # {"id": 1}'
   )
 
   mocks="$(run_steps "setup")"
@@ -102,11 +102,11 @@ load ../_helper.bash
 
   declare -a STEPS=(
     # GET existing comments - return one with marker.
-    '@curl -s -H Authorization: token token12345 -H Accept: application/vnd.github.v3+json https://api.github.com/repos/myorg/myrepo/issues/456/comments?per_page=100 # [{"node_id": "MDEyOklzc3VlQ29tbWVudDE=", "body": "old coverage <!-- coverage-circleci -->"}]'
+    '@curl * # [{"node_id": "MDEyOklzc3VlQ29tbWVudDE=", "body": "old coverage <!-- coverage-circleci -->"}]'
     # POST GraphQL to minimize existing comment.
-    '@curl -s -X POST -H Authorization: bearer token12345 -H Content-Type: application/json https://api.github.com/graphql * # {"data":{"minimizeComment":{"minimizedComment":{"isMinimized":true}}}}'
+    '@curl * # {"data":{"minimizeComment":{"minimizedComment":{"isMinimized":true}}}}'
     # POST new comment.
-    '@curl -s -X POST -H Authorization: token token12345 -H Accept: application/vnd.github.v3+json https://api.github.com/repos/myorg/myrepo/issues/456/comments * # {"id": 2}'
+    '@curl * # {"id": 2}'
   )
 
   mocks="$(run_steps "setup")"