[#2388] Switched to PHP 8.4.

Author: AlexSkrypnyk

.docker/cli.dockerfile

@@ -4,10 +4,10 @@
 #
 # hadolint global ignore=DL3018,SC2174
 #
-# @see https://hub.docker.com/r/uselagoon/php-8.3-cli-drupal/tags
+# @see https://hub.docker.com/r/uselagoon/php-8.4-cli-drupal/tags
 # @see https://github.com/uselagoon/lagoon-images/tree/main/images/php-cli-drupal
 
-FROM uselagoon/php-8.3-cli-drupal:26.2.0
+FROM uselagoon/php-8.4-cli-drupal:26.2.0
 
 # Add missing variables.
 # @todo Remove once https://github.com/uselagoon/lagoon/issues/3121 is resolved.

.docker/php.dockerfile

@@ -5,14 +5,14 @@
 #
 # hadolint global ignore=DL3018
 #
-# @see https://hub.docker.com/r/uselagoon/php-8.3-fpm/tags
+# @see https://hub.docker.com/r/uselagoon/php-8.4-fpm/tags
 # @see https://github.com/uselagoon/lagoon-images/tree/main/images/php-fpm
 
 ARG CLI_IMAGE
 # hadolint ignore=DL3006
 FROM ${CLI_IMAGE:-cli} AS cli
 
-FROM uselagoon/php-8.3-fpm:26.2.0
+FROM uselagoon/php-8.4-fpm:26.2.0
 
 RUN apk add --no-cache tzdata
 

.vortex/installer/tests/Fixtures/handler_process/_baseline/.docker/cli.dockerfile

@@ -4,10 +4,10 @@
 #
 # hadolint global ignore=DL3018,SC2174
 #
-# @see https://hub.docker.com/r/uselagoon/php-8.3-cli-drupal/tags
+# @see https://hub.docker.com/r/uselagoon/php-8.4-cli-drupal/tags
 # @see https://github.com/uselagoon/lagoon-images/tree/main/images/php-cli-drupal
 
-FROM uselagoon/php-8.3-cli-drupal:__VERSION__
+FROM uselagoon/php-8.4-cli-drupal:__VERSION__
 
 # Add missing variables.
 # @todo Remove once https://github.com/uselagoon/lagoon/issues/3121 is resolved.

.vortex/installer/tests/Fixtures/handler_process/_baseline/.docker/php.dockerfile

@@ -5,14 +5,14 @@
 #
 # hadolint global ignore=DL3018
 #
-# @see https://hub.docker.com/r/uselagoon/php-8.3-fpm/tags
+# @see https://hub.docker.com/r/uselagoon/php-8.4-fpm/tags
 # @see https://github.com/uselagoon/lagoon-images/tree/main/images/php-fpm
 
 ARG CLI_IMAGE
 # hadolint ignore=DL3006
 FROM ${CLI_IMAGE:-cli} AS cli
 
-FROM uselagoon/php-8.3-fpm:__VERSION__
+FROM uselagoon/php-8.4-fpm:__VERSION__
 
 RUN apk add --no-cache tzdata
 

.vortex/installer/tests/Fixtures/handler_process/_baseline/phpcs.xml

@@ -27,7 +27,7 @@
     <arg name="parallel" value="10"/>
 
     <!-- Lint code against platform version specified in composer.json key "config.platform.php". -->
-    <config name="testVersion" value="8.3"/>
+    <config name="testVersion" value="8.4"/>
 
     <!-- Exclude theme assets. -->
     <exclude-pattern>web\/themes\/custom\/.*\/build\/.*</exclude-pattern>

.vortex/installer/tests/Fixtures/handler_process/_baseline/phpunit.xml

@@ -28,7 +28,7 @@
          cacheDirectory=".phpunit.cache">
     <php>
         <!-- Set error reporting to E_ALL. -->
-        <ini name="error_reporting" value="32767"/>
+        <ini name="error_reporting" value="30719"/>
         <!-- Do not limit the amount of memory tests take to run. -->
         <ini name="memory_limit" value="-1"/>
         <env name="SIMPLETEST_BASE_URL" value="http://nginx:8080"/>

.vortex/installer/tests/Fixtures/handler_process/_baseline/rector.php

@@ -79,9 +79,9 @@
     '*/vendor/*',
     '*/node_modules/*',
   ])
-  // PHP version upgrade sets - modernizes syntax to PHP 8.3.
-  // Includes all rules from PHP 5.3 through 8.3.
-  ->withPhpSets(php83: TRUE)
+  // PHP version upgrade sets - modernizes syntax to PHP 8.4.
+  // Includes all rules from PHP 5.3 through 8.4.
+  ->withPhpSets(php84: TRUE)
   // Code quality improvement sets.
   ->withPreparedSets(
     codeQuality: TRUE,

.vortex/installer/tests/Fixtures/handler_process/_baseline/tests/phpunit/Drupal/SettingsTestCase.php

@@ -176,15 +176,7 @@ protected function setEnvVars(array $vars): void {
   protected static function getRealEnvVarsFilteredNoValues(array $prefixes = []): array {
     $vars = getenv();
 
-    $vars = array_filter(array_keys($vars), static function (string $key) use ($prefixes): bool {
-      foreach ($prefixes as $prefix) {
-        if (str_starts_with($key, $prefix)) {
-          return TRUE;
-        }
-      }
-
-      return FALSE;
-    });
+    $vars = array_filter(array_keys($vars), static fn(string $key): bool => array_any($prefixes, fn($prefix): bool => str_starts_with($key, (string) $prefix)));
 
     return array_fill_keys($vars, NULL);
   }

.vortex/installer/tests/Fixtures/handler_process/hosting_acquia/phpcs.xml

@@ -14,7 +14,7 @@
 
      <rule ref="Drupal"/>
 @@ -30,10 +30,10 @@
-     <config name="testVersion" value="8.3"/>
+     <config name="testVersion" value="8.4"/>
 
      <!-- Exclude theme assets. -->
 -    <exclude-pattern>web\/themes\/custom\/.*\/build\/.*</exclude-pattern>

.vortex/installer/tests/Fixtures/handler_process/hosting_acquia/tests/phpunit/Drupal/SettingsTestCase.php

@@ -1,4 +1,4 @@
-@@ -202,7 +202,7 @@
+@@ -194,7 +194,7 @@
     * Require settings file.
     */
    protected function requireSettingsFile(array $pre_settings = [], array $pre_config = []): void {