[#2106] Updated require-dev to use only necessary packages and updated PHPCS to v4 and Coder to v9.

Author: AlexSkrypnyk

.vortex/docs/content/drupal/composer.mdx

@@ -141,6 +141,10 @@ effective development environment.
   Behavior-Driven Development (BDD), allowing you to write human-readable
   stories that describe the behavior of your application. It facilitates
   communication between developers, stakeholders, and clients.
+- [`dantleech/gherkin-lint`](https://github.com/dantleech/gherkin-lint): A
+  linting tool for Gherkin feature files used in Behat tests. Ensures
+  consistency and quality in BDD test scenarios by checking syntax and
+  formatting.
 - [`dealerdirect/phpcodesniffer-composer-installer`](https://github.com/Dealerdirect/phpcodesniffer-composer-installer):
   This tool automatically configures PHP_CodeSniffer to use the coding
   standards (like PSR-2 or Drupal coding standards) installed in a project.
@@ -154,10 +158,12 @@ effective development environment.
   collection of pre-defined step definitions for Behat. This package speeds up
   the process of writing new Behat tests by providing common step
   implementations.
-- [`drupal/core-dev`](https://www.drupal.org/project/drupal): Includes
-  development-specific dependencies and tools primarily for testing and code
-  analysis, including PHPUnit, PHP_CodeSniffer with rules (
-  via [Coder](https://www.drupal.org/project/coder) module).
+- [`drevops/phpcs-standard`](https://github.com/drevops/phpcs-standard): A
+  custom PHP_CodeSniffer coding standard that extends Drupal coding standards
+  with additional rules and best practices specific to DrevOps projects.
+- [`drupal/coder`](https://www.drupal.org/project/coder): Provides
+  PHP_CodeSniffer rules for Drupal coding standards. Version 9.x supports
+  PHP_CodeSniffer 4.x and includes updated rules for modern Drupal development.
 - [`drupal/drupal-extension`](https://github.com/jhedstrom/drupalextension): A
   Behat extension that provides integration with Drupal, offering step
   definitions specific to Drupal functionality. It facilitates the creation and
@@ -173,7 +179,7 @@ effective development environment.
 - [`phpcompatibility/php-compatibility`](https://github.com/PHPCompatibility/PHPCompatibility):
   Provides a collection of sniffs for PHP_CodeSniffer to check PHP code for
   compatibility with different PHP versions, crucial for ensuring long-term
-  maintainability.
+  maintainability. Version 10.x supports PHP_CodeSniffer 4.x.
 - [`phpmd/phpmd`](https://github.com/phpmd/phpmd): PHP Mess Detector is a
   user-friendly tool that helps you detect several potential problems in your
   PHP code, including possible bugs, suboptimal code, and overcomplicated
@@ -184,10 +190,22 @@ effective development environment.
 - [`phpstan/extension-installer`](https://github.com/phpstan/extension-installer):
   This package automatically installs and enables PHPStan extensions,
   streamlining the setup process for PHPStan in your project.
+- [`phpstan/phpstan`](https://github.com/phpstan/phpstan): A static analysis
+  tool for PHP that focuses on finding bugs in code without running it. Helps
+  catch type errors, incorrect method calls, and other potential issues during
+  development.
+- [`phpunit/phpunit`](https://github.com/sebastianbergmann/phpunit): The
+  industry-standard testing framework for PHP. Provides a comprehensive set of
+  tools for writing and running unit tests, integration tests, and functional
+  tests.
 - [`pyrech/composer-changelogs`](https://github.com/pyrech/composer-changelogs):
   Provides a summary of package changes (like updates, removals, and additions)
   after running `composer update`, improving the visibility of package changes
   and updates in your project.
+- [`rector/rector`](https://github.com/rectorphp/rector): An automated
+  refactoring tool that instantly upgrades and refactors PHP code. Helps with
+  code modernization, framework migrations, and automated application of coding
+  standards.
 - [`vincentlanglet/twig-cs-fixer`](https://github.com/VincentLanglet/Twig-CS-Fixer): This tool
   ensures that Twig templates adhere to a set coding standard, helping maintain
   consistency and readability in template files.

.vortex/docs/cspell.json

@@ -29,6 +29,7 @@
         "containerisation",
         "customisations",
         "cweagans",
+        "dantleech",
         "dclint",
         "ddev",
         "dealerdirect",

.vortex/installer/composer.json

@@ -37,7 +37,7 @@
         "bamarni/composer-bin-plugin": "^1.8.2",
         "dealerdirect/phpcodesniffer-composer-installer": "^1.2.0",
         "drevops/phpcs-standard": "^0.6",
-        "drupal/coder": "^8.3.31",
+        "drupal/coder": "^9@alpha",
         "ergebnis/composer-normalize": "^2.48.2",
         "laravel/serializable-closure": "^2.0.6",
         "mockery/mockery": "^1.6.12",

.vortex/installer/composer.lock

@@ -181,12 +181,16 @@ public static function getToolDefinitions(string $filter = 'all'): array {
         'present' => fn(): mixed => File::contains($this->dstDir . '/composer.json', 'dealerdirect/phpcodesniffer-composer-installer') ||
         File::contains($this->dstDir . '/composer.json', 'drupal/coder') ||
         File::contains($this->dstDir . '/composer.json', 'squizlabs/php_codesniffer') ||
+        File::contains($this->dstDir . '/composer.json', 'phpcompatibility/php-compatibility') ||
+        File::contains($this->dstDir . '/composer.json', 'drevops/phpcs-standard') ||
         File::exists($this->dstDir . '/phpcs.xml'),
         'composer.json' => function (JsonManipulator $cj): void {
           $cj->removeSubNode('require-dev', 'dealerdirect/phpcodesniffer-composer-installer');
           $cj->removeConfigSetting('allow-plugins.dealerdirect/phpcodesniffer-composer-installer');
           $cj->removeSubNode('require-dev', 'drupal/coder');
           $cj->removeSubNode('require-dev', 'squizlabs/php_codesniffer');
+          $cj->removeSubNode('require-dev', 'phpcompatibility/php-compatibility');
+          $cj->removeSubNode('require-dev', 'drevops/phpcs-standard');
         },
         'files' => ['phpcs.xml'],
         'strings' => [
@@ -200,10 +204,13 @@ public static function getToolDefinitions(string $filter = 'all'): array {
         'title' => 'PHPStan',
         'present' => fn(): mixed => File::contains($this->dstDir . '/composer.json', 'phpstan/phpstan') ||
         File::contains($this->dstDir . '/composer.json', 'mglaman/phpstan-drupal') ||
+        File::contains($this->dstDir . '/composer.json', 'phpstan/extension-installer') ||
         File::exists($this->dstDir . '/phpstan.neon'),
         'composer.json' => function (JsonManipulator $cj): void {
           $cj->removeSubNode('require-dev', 'phpstan/phpstan');
           $cj->removeSubNode('require-dev', 'mglaman/phpstan-drupal');
+          $cj->removeSubNode('require-dev', 'phpstan/extension-installer');
+          $cj->removeConfigSetting('allow-plugins.phpstan/extension-installer');
         },
         'files' => ['phpstan.neon'],
         'strings' => [
@@ -220,6 +227,7 @@ public static function getToolDefinitions(string $filter = 'all'): array {
         File::exists($this->dstDir . '/rector.php'),
         'composer.json' => function (JsonManipulator $cj): void {
           $cj->removeSubNode('require-dev', 'rector/rector');
+          $cj->removeSubNode('require-dev', 'palantirnet/drupal-rector');
         },
         'files' => ['rector.php'],
         'strings' => ['/^.*\brector\b.*\n?/m'],
@@ -244,9 +252,11 @@ public static function getToolDefinitions(string $filter = 'all'): array {
       self::PHPUNIT => [
         'title' => 'PHPUnit',
         'present' => fn(): mixed => File::contains($this->dstDir . '/composer.json', 'phpunit/phpunit') ||
+        File::contains($this->dstDir . '/composer.json', 'phpspec/prophecy-phpunit') ||
         File::exists($this->dstDir . '/phpunit.xml'),
         'composer.json' => function (JsonManipulator $cj): void {
           $cj->removeSubNode('require-dev', 'phpunit/phpunit');
+          $cj->removeSubNode('require-dev', 'phpspec/prophecy-phpunit');
           $cj->removeProperty('autoload-dev.classmap');
           $cj->removeMainKeyIfEmpty('autoload-dev');
         },
@@ -273,11 +283,17 @@ public static function getToolDefinitions(string $filter = 'all'): array {
         'title' => 'Behat',
         'present' => fn(): mixed => File::contains($this->dstDir . '/composer.json', 'behat/behat') ||
         File::contains($this->dstDir . '/composer.json', 'drupal/drupal-extension') ||
+        File::contains($this->dstDir . '/composer.json', 'drevops/behat-format-progress-fail') ||
+        File::contains($this->dstDir . '/composer.json', 'drevops/behat-screenshot') ||
+        File::contains($this->dstDir . '/composer.json', 'drevops/behat-steps') ||
         File::exists($this->dstDir . '/behat.yml'),
         'composer.json' => function (JsonManipulator $cj): void {
           $cj->removeSubNode('require-dev', 'behat/behat');
           $cj->removeSubNode('require-dev', 'drupal/drupal-extension');
           $cj->removeSubNode('require-dev', 'dantleech/gherkin-lint');
+          $cj->removeSubNode('require-dev', 'drevops/behat-format-progress-fail');
+          $cj->removeSubNode('require-dev', 'drevops/behat-screenshot');
+          $cj->removeSubNode('require-dev', 'drevops/behat-steps');
         },
         'files' => [
           'behat.yml',

.vortex/installer/src/Prompts/Handlers/Tools.php

@@ -36,16 +36,18 @@
         "drevops/behat-screenshot": "__VERSION__",
         "drevops/behat-steps": "__VERSION__",
         "drevops/phpcs-standard": "__VERSION__",
-        "drupal/core-dev": "__VERSION__",
+        "drupal/coder": "__VERSION__",
         "drupal/drupal-extension": "__VERSION__",
         "ergebnis/composer-normalize": "__VERSION__",
         "mglaman/phpstan-drupal": "__VERSION__",
+        "mikey179/vfsstream": "__VERSION__",
         "palantirnet/drupal-rector": "__VERSION__",
         "phpcompatibility/php-compatibility": "__VERSION__",
         "phpmd/phpmd": "__VERSION__",
         "phpspec/prophecy-phpunit": "__VERSION__",
         "phpstan/extension-installer": "__VERSION__",
         "phpstan/phpstan": "__VERSION__",
+        "phpunit/phpunit": "__VERSION__",
         "pyrech/composer-changelogs": "__VERSION__",
         "rector/rector": "__VERSION__",
         "vincentlanglet/twig-cs-fixer": "__VERSION__"

.vortex/installer/tests/Fixtures/install/_baseline/composer.json

@@ -1,4 +1,4 @@
-@@ -117,40 +117,40 @@
+@@ -119,40 +119,40 @@
                  "[web-root]/web.config": false
              },
              "locations": {

.vortex/installer/tests/Fixtures/install/hosting_acquia/composer.json

@@ -1,4 +1,4 @@
-@@ -117,40 +117,40 @@
+@@ -119,40 +119,40 @@
                  "[web-root]/web.config": false
              },
              "locations": {

.vortex/installer/tests/Fixtures/install/hosting_project_name___acquia/composer.json

@@ -17,7 +17,7 @@
      },
      "require-dev": {
          "behat/behat": "__VERSION__",
-@@ -59,7 +62,7 @@
+@@ -61,7 +64,7 @@
              "url": "https://packages.drupal.org/8"
          }
      ],
@@ -26,7 +26,7 @@
      "prefer-stable": true,
      "autoload": {
          "classmap": [
-@@ -82,7 +85,11 @@
+@@ -84,7 +87,11 @@
              "php-http/discovery": true,
              "phpstan/extension-installer": true,
              "pyrech/composer-changelogs": true,
@@ -39,7 +39,7 @@
          },
          "audit": {
              "abandoned": "report",
-@@ -162,7 +169,20 @@
+@@ -164,7 +171,20 @@
          "patchLevel": {
              "drupal/core": "-p2"
          },