Skip to content

Fixed Renovate config. #1686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlexSkrypnyk merged 2 commits into from
May 31, 2025
Merged

Fixed Renovate config. #1686

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
596c051
Fixed renovate validator.
AlexSkrypnyk May 31, 2025
c45b926
Even up NodeJs versions.
AlexSkrypnyk May 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -410,7 +410,7 @@ jobs:
# Add RENOVATE_TOKEN as an environment variable with GitHub access token in UI.
deps-updates:
docker:
- image: renovate/renovate:40.8.2
- image: renovate/renovate:40.36.8
environment:
RENOVATE_PLATFORM: 'github'
RENOVATE_AUTODISCOVER: false
Expand Down
6 changes: 4 additions & 2 deletions .github/workflows/deps-updates.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,11 @@ jobs:
- name: Checkout
uses: actions/checkout@v4.2.2

- uses: suzuki-shunsuke/github-action-renovate-config-validator@v1.1.1
- uses: actions/setup-node@v4.4.0
with:
node-version: 22.13.1
node-version: 22.16.0

- uses: suzuki-shunsuke/github-action-renovate-config-validator@v1.1.1

Comment on lines +14 to 19

@coderabbitai coderabbitai Bot May 31, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick (assertive)

Setup Node.js (22.16.0) and validate Renovate config
Adding actions/setup-node@v4.4.0 with node-version: 22.16.0 and the github-action-renovate-config-validator step aligns this workflow with others.

You may consider using the unpinned major reference (actions/setup-node@v4) instead of v4.4.0 to automatically pick up patch releases across all workflows.

🤖 Prompt for AI Agents 
In .github/workflows/deps-updates.yml around lines 14 to 19, the setup-node
action is pinned to version v4.4.0. To keep the workflow updated with the latest
patch releases automatically, change the action reference from
'actions/setup-node@v4.4.0' to 'actions/setup-node@v4' so it uses the unpinned
major version.

- name: Check Renovate Token
id: check-token
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/vortex-release-docs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,8 @@ jobs:

- name: Setup Node.js
uses: actions/setup-node@v4
with:
node-version: 22.16.0

- name: Setup PHP
uses: shivammathur/setup-php@v2
Expand Down
8 changes: 8 additions & 0 deletions .github/workflows/vortex-test-common.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,8 @@ jobs:

- name: Setup Node.js
uses: actions/setup-node@v4
with:
node-version: 22.16.0

- name: Install dependencies
run: yarn install --frozen-lockfile
Expand All @@ -72,6 +74,12 @@ jobs:
./tests/lint.dockerfiles.sh
working-directory: .vortex

# Special case to validate Renovate configuration with the same action
# as used in the Renovate workflow to ensure that they both use the same
# version.
- name: Validate Renovate configuration
uses: suzuki-shunsuke/github-action-renovate-config-validator@v1.1.1

- name: Run tests
run: ./tests/test.common.sh
working-directory: .vortex
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/vortex-test-docs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@ jobs:

- name: Setup Node.js
uses: actions/setup-node@v4
with:
node-version: 22.16.0

- name: Setup PHP
uses: shivammathur/setup-php@v2
Expand Down
6 changes: 4 additions & 2 deletions .vortex/installer/tests/Fixtures/install/_baseline/.github/workflows/deps-updates.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,11 @@ jobs:
- name: Checkout
uses: actions/checkout@__VERSION__

- uses: suzuki-shunsuke/github-action-renovate-config-validator@__VERSION__
- uses: actions/setup-node@__VERSION__
with:
node-version: 22.13.1
node-version: 22.16.0

- uses: suzuki-shunsuke/github-action-renovate-config-validator@__VERSION__

- name: Check Renovate Token
id: check-token
Expand Down
2 changes: 1 addition & 1 deletion .vortex/installer/tests/Fixtures/install/names/.github/workflows/deps-updates.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@@ -37,4 +37,4 @@
@@ -39,4 +39,4 @@
RENOVATE_DEPENDENCY_DASHBOARD_TITLE: 'Renovate Dependency Dashboard (self-hosted) by GitHub Actions'
RENOVATE_DEPENDENCY_DASHBOARD: ${{ vars.RENOVATE_DEPENDENCY_DASHBOARD || 'false' }}
RENOVATE_DRY_RUN: ${{ vars.RENOVATE_DRY_RUN || 'false' }}
Expand Down