Removed `VORTEX_DOWNLOAD_DB_SSH_KNOWN_HOSTS` in favour of `known_hosts: unnecessary`. by AlexSkrypnyk · Pull Request #1691 · drevops/vortex

AlexSkrypnyk · 2025-05-31T12:28:54Z

Summary by CodeRabbit

Chores
- Updated workflow configuration to simplify SSH key setup by replacing the known hosts value with a placeholder.
- Removed the database provisioning job and related steps from certain workflow configurations.
- Cleaned up workflow triggers and dependencies for improved maintainability.

…s: unnecessary`.

coderabbitai · 2025-05-31T12:29:01Z

Walkthrough

This update modifies GitHub Actions workflows by changing the known_hosts input for the SSH key action from a secret to the literal string "unnecessary" in multiple workflow files. Additionally, one workflow fixture removes the entire database job, its dependencies, and related environment variables and steps.

Changes

Files/Paths	Summary of Changes
.github/workflows/build-test-deploy.yml .vortex/installer/tests/Fixtures/install/_baseline/.github/workflows/build-test-deploy.yml	Changed `known_hosts` input for the SSH key action from a secret to the string "unnecessary".
.vortex/installer/tests/Fixtures/install/provision_profile/.github/workflows/build-test-deploy.yml	Removed the `database` job, all related environment variables, database caching, and dependencies.

Sequence Diagram(s)

sequenceDiagram
    participant GitHub Actions
    participant Runner

    GitHub Actions->>Runner: Start workflow
    alt With database job (before)
        Runner->>Runner: Add SSH key (known_hosts from secret)
        Runner->>Runner: Download and cache database
        Runner->>Runner: Build (needs: database)
        Runner->>Runner: Deploy (conditional)
    else Without database job (after)
        Runner->>Runner: Build (no database dependency)
        Runner->>Runner: Deploy (no conditional)
    end

Possibly related PRs

[#1636]: Marked known_hosts: unnecessary. #1651: Changes the known_hosts input for the SSH key action in the deploy job to "unnecessary", similar to this PR's change in the database job.

Suggested labels

PR: Needs review

Poem

A bunny hopped through YAML fields,
Where secrets once were tightly sealed.
"Unnecessary!" it did declare,
And simplified the workflow there.
With database jobs now out of sight,
The pipeline runs so swift and light!
🐇✨

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2bc44ac and 425f2b7.

📒 Files selected for processing (3)

.github/workflows/build-test-deploy.yml (1 hunks)
.vortex/installer/tests/Fixtures/install/_baseline/.github/workflows/build-test-deploy.yml (1 hunks)
.vortex/installer/tests/Fixtures/install/provision_profile/.github/workflows/build-test-deploy.yml (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (8)

GitHub Check: build (1)
GitHub Check: build (0)
GitHub Check: vortex-test-deployment (1)
GitHub Check: vortex-test-deployment (0)
GitHub Check: vortex-test-workflow (2)
GitHub Check: vortex-test-workflow (0)
GitHub Check: vortex-test-workflow (3)
GitHub Check: vortex-test-workflow (1)

🔇 Additional comments (4)

.vortex/installer/tests/Fixtures/install/_baseline/.github/workflows/build-test-deploy.yml (1)

88-88: Update baseline fixture known_hosts input to unnecessary
The literal string replaces the removed secret reference, aligning with other workflows. Please verify that any snapshot or fixture-based tests are updated to expect known_hosts: unnecessary.

.github/workflows/build-test-deploy.yml (2)

88-88: Disable SSH host key checking in database job
Setting known_hosts: unnecessary correctly disables host verification for the DB SSH action. Confirm that the version injected into shimataro/ssh-key-action@__VERSION__ supports this flag.

398-398: Mirror known_hosts change in deploy job
The deploy step now also uses known_hosts: unnecessary, keeping consistency across SSH key actions. All other parameters appear correct.

.vortex/installer/tests/Fixtures/install/provision_profile/.github/workflows/build-test-deploy.yml (1)

5-6: Remove scheduled trigger for provision_profile workflow
Dropping the schedule block prevents unintended daily runs, which is appropriate for a profile intended for manual or PR-triggered execution.

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

codecov · 2025-05-31T12:37:41Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.50%. Comparing base (2bc44ac) to head (425f2b7).
Report is 1 commits behind head on develop.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #1691   +/-   ##
========================================
  Coverage    70.50%   70.50%           
========================================
  Files           76       76           
  Lines         4347     4347           
========================================
  Hits          3065     3065           
  Misses        1282     1282

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Removed VORTEX_DOWNLOAD_DB_SSH_KNOWN_HOSTS in favour of `known_host…

425f2b7

…s: unnecessary`.

github-project-automation Bot added this to Vortex May 31, 2025

github-project-automation Bot moved this to BACKLOG in Vortex May 31, 2025

github-actions Bot assigned AlexSkrypnyk May 31, 2025

github-actions Bot temporarily deployed to commit May 31, 2025 12:30 Inactive

AlexSkrypnyk merged commit f24fb5b into develop May 31, 2025
30 checks passed

AlexSkrypnyk deleted the feature/1674-remove-gha-var branch May 31, 2025 13:37

github-project-automation Bot moved this from BACKLOG to Release queue in Vortex May 31, 2025

AlexSkrypnyk moved this from Release queue to Released in 25.6.0 in Vortex Jul 26, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Removed `VORTEX_DOWNLOAD_DB_SSH_KNOWN_HOSTS` in favour of `known_hosts: unnecessary`.#1691

Removed `VORTEX_DOWNLOAD_DB_SSH_KNOWN_HOSTS` in favour of `known_hosts: unnecessary`.#1691
AlexSkrypnyk merged 1 commit into
developfrom
feature/1674-remove-gha-var

AlexSkrypnyk commented May 31, 2025 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented May 31, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

codecov Bot commented May 31, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

AlexSkrypnyk commented May 31, 2025 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented May 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Possibly related PRs

Suggested labels

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

codecov Bot commented May 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

AlexSkrypnyk commented May 31, 2025 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented May 31, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

codecov Bot commented May 31, 2025 •

edited

Loading