-
-
Notifications
You must be signed in to change notification settings - Fork 29
Removed all emojis from the installer. #1954
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -18,7 +18,7 @@ class CiProvider extends AbstractHandler { | |
| * {@inheritdoc} | ||
| */ | ||
| public function label(): string { | ||
| return '🔄 Continuous Integration provider'; | ||
| return 'Continuous Integration provider'; | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 💡 Verification agent 🧩 Analysis chainVerify no stray emojis remain across the installer. Run the scan below to catch any remaining emoji-like glyphs (allows ✓, ✕, ⬆, ⬇ as per tests/prompts). 🏁 Script executed: #!/bin/bash
set -euo pipefail
python - <<'PY'
import os, sys
root='.vortex/installer'
allow={'✓','✕','⬆','⬇'}
ranges=[(0x1F300,0x1FAFF),(0x1F1E6,0x1F1FF),(0x1F900,0x1F9FF),(0x1F680,0x1F6FF),
(0x1F700,0x1F77F),(0x2600,0x26FF),(0x2700,0x27BF),(0x1FA70,0x1FAFF),(0x1F300,0x1F5FF)]
VS16=0xFE0F; ZWJ=0x200D
def is_emoji(cp):
if cp in (VS16, ZWJ): return True
for a,b in ranges:
if a<=cp<=b: return True
return False
hits=0
for dp, dns, fns in os.walk(root):
dns[:]=[d for d in dns if d not in ('.git','vendor','node_modules','build','dist')]
for fn in fns:
p=os.path.join(dp,fn)
try:
with open(p,'r',encoding='utf-8',errors='ignore') as f:
for i,line in enumerate(f,1):
chars=[ch for ch in line if ch not in allow and is_emoji(ord(ch))]
if chars:
print(f'{p}:{i}: ' + ''.join(chars).encode('unicode_escape').decode('ascii') + ' -> ' + line.strip())
hits+=1
except Exception: pass
if hits:
print(f'Found {hits} emoji-like characters', file=sys.stderr); sys.exit(1)
print('No non-allowed emoji found.')
PYLength of output: 1451 Remove non-allowed emoji-like characters Found 15 non-allowed emoji across the installer; remove or replace the following occurrences:
🤖 Prompt for AI Agents |
||
| } | ||
|
|
||
| /** | ||
|
|
||
| Original file line number | Diff line number | Diff line change | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -15,7 +15,7 @@ class DatabaseImage extends AbstractHandler { | |||||||||||||||
| * {@inheritdoc} | ||||||||||||||||
| */ | ||||||||||||||||
| public function label(): string { | ||||||||||||||||
| return '🏷️ What is your database container image name and a tag?'; | ||||||||||||||||
| return 'What is your database container image name and a tag?'; | ||||||||||||||||
| } | ||||||||||||||||
|
Comment on lines
17
to
19
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧹 Nitpick (assertive) Minor grammar tweak for clarity Drop the article before “tag”. - return 'What is your database container image name and a tag?';
+ return 'What is your database container image name and tag?';📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||||||||||||
|
|
||||||||||||||||
| /** | ||||||||||||||||
|
|
||||||||||||||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -14,7 +14,7 @@ class OrgMachineName extends AbstractHandler { | |
| * {@inheritdoc} | ||
| */ | ||
| public function label(): string { | ||
| return '🏢 Organization machine name'; | ||
| return 'Organization machine name'; | ||
| } | ||
|
Comment on lines
16
to
18
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧹 Nitpick (assertive) Consistency: US vs UK spelling Label uses “Organization” while the validation message elsewhere says “organisation.” Consider standardizing across prompts. 🤖 Prompt for AI Agents |
||
|
|
||
| /** | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
🧩 Analysis chain
Show the “committed files may be modified” warning also for any existing Git repo, not only Vortex projects
If a non-Vortex project directory is already a Git repo, users can still get modifications/overwrites. Suggest broadening the condition to reduce surprise.
Apply:
Add helper (outside this block):
🏁 Script executed:
Length of output: 2899
Handle nullable destination when broadening the warning to all Git repos
In the interactive branch of
.vortex/installer/src/Command/InstallCommand.php(around lines 449–454), guard againstgetDst()returning null and include any Git repo:Add this helper (you can keep it
protectedsince you guard null above):🤖 Prompt for AI Agents