-
-
Notifications
You must be signed in to change notification settings - Fork 29
Updated scripts to match their counterparts. #2312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -54,13 +54,13 @@ $deploy_git_user_email = getenv_required('VORTEX_DEPLOY_ARTIFACT_GIT_USER_EMAIL' | |
|
|
||
| // SSH key fingerprint used to connect to remote. | ||
| // | ||
| // Falls back to $VORTEX_SSH_FINGERPRINT. | ||
| $deploy_ssh_fingerprint = getenv_default('VORTEX_DEPLOY_SSH_FINGERPRINT', 'VORTEX_SSH_FINGERPRINT', ''); | ||
| // Falls back to VORTEX_DEPLOY_SSH_FINGERPRINT, then VORTEX_SSH_FINGERPRINT. | ||
| $deploy_ssh_fingerprint = getenv_default('VORTEX_DEPLOY_ARTIFACT_SSH_FINGERPRINT', 'VORTEX_DEPLOY_SSH_FINGERPRINT', 'VORTEX_SSH_FINGERPRINT', ''); | ||
|
|
||
| // Default SSH file used if custom fingerprint is not provided. | ||
| // | ||
| // Falls back to VORTEX_SSH_FILE. | ||
| $deploy_ssh_file = getenv_default('VORTEX_DEPLOY_SSH_FILE', 'VORTEX_SSH_FILE', getenv('HOME') . '/.ssh/id_rsa'); | ||
| // Falls back to VORTEX_DEPLOY_SSH_FILE, then VORTEX_SSH_FILE. | ||
| $deploy_ssh_file = getenv_default('VORTEX_DEPLOY_ARTIFACT_SSH_FILE', 'VORTEX_DEPLOY_SSH_FILE', 'VORTEX_SSH_FILE', getenv('HOME') . '/.ssh/id_rsa'); | ||
|
|
||
| // ----------------------------------------------------------------------------- | ||
|
|
||
|
|
@@ -86,16 +86,16 @@ if (empty($global_git_email)) { | |
| } | ||
|
|
||
| // Setup SSH. | ||
| putenv('VORTEX_SSH_PREFIX=DEPLOY'); | ||
| !empty($deploy_ssh_fingerprint) && putenv('VORTEX_DEPLOY_SSH_FINGERPRINT=' . $deploy_ssh_fingerprint); | ||
| !empty($deploy_ssh_file) && putenv('VORTEX_DEPLOY_SSH_FILE=' . $deploy_ssh_file); | ||
| putenv('VORTEX_SSH_PREFIX=DEPLOY_ARTIFACT'); | ||
| !empty($deploy_ssh_fingerprint) && putenv('VORTEX_DEPLOY_ARTIFACT_SSH_FINGERPRINT=' . $deploy_ssh_fingerprint); | ||
| !empty($deploy_ssh_file) && putenv('VORTEX_DEPLOY_ARTIFACT_SSH_FILE=' . $deploy_ssh_file); | ||
| passthru(__DIR__ . '/setup-ssh', $exit_code); | ||
| if ($exit_code !== 0) { | ||
| quit($exit_code); | ||
| } | ||
|
|
||
| task('Installing artifact builder.'); | ||
| passthru('composer global require --dev -n --ansi --prefer-source --ignore-platform-reqs drevops/git-artifact:~1.1', $exit_code); | ||
| passthru('composer global require --dev -n --ansi --prefer-source --ignore-platform-reqs drevops/git-artifact:~1.2', $exit_code); | ||
| if ($exit_code !== 0) { | ||
|
Comment on lines
97
to
99
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
# Check git-artifact versions and requirements on Packagist.
echo "=== Checking available 1.2.x versions ==="
curl -s https://packagist.org/packages/drevops/git-artifact.json | jq -r '.package.versions | keys[]' | grep -E '^1\.2' || echo "No versions found"
echo -e "\n=== Checking PHP requirements for 1.2.0 ==="
curl -s https://packagist.org/packages/drevops/git-artifact.json | jq -r '.package.versions["1.2.0"] // empty' | head -20Repository: drevops/vortex Length of output: 707 🏁 Script executed: #!/bin/bash
# Get full PHP requirements for version 1.2.0
curl -s https://packagist.org/packages/drevops/git-artifact.json | jq -r '.package.versions["1.2.0"].require' 2>/dev/null || echo "Failed to retrieve requirements"Repository: drevops/vortex Length of output: 302 Verify PHP 8.3+ availability in CI environment. 🤖 Prompt for AI Agents |
||
| quit($exit_code); | ||
| } | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix the “required Added” wording in the Phase 5.5 bullet.
The bullet reads awkwardly; splitting it removes the double-modal.
✍️ Suggested wording fix
🧰 Tools
🪛 LanguageTool
[style] ~768-~768: The double modal “required Added” is nonstandard (only accepted in certain dialects). Consider “to be Added”.
Context: ...ONMENT_URL
from optional to required - Addedputenv()` exports for branch, SHA, PR ...(NEEDS_FIXED)
🤖 Prompt for AI Agents