Req.uncacheable#1
Open
gquintard wants to merge 1 commit into
Open
Conversation
The current way to bypass the cache is to either `return(pass)` in `vcl_recv` or to trigger an HfP/HfM on the backend side. The former forces you to interrupt the request processing, such as header normalization, or to set a variable/header to remember your choice so that you can return `pass` once processing is done. The latter is nicer but has to deal with request coalescing and it doesn't really make sense to wait that long before make this decision. `req.uncacheable` mirrors `bereq.uncacheable` but really just transforms a `return(hash)` into a `return(pass)`. This means that it has priority over `req.hash_always_miss` but also operate slightly earlier, at the end of vcl_recv` rather than at the end of `vcl_hash`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
there you go.
One note:
REQ_FLAGSare a bit different fromBO_FLAGS, and have an automatic VRT implementation, which notably means thatreq.uncacheablecan be set back tofalse