feat: add rule for Laravel Timestamps property to attribute#491
Open
yoannblot wants to merge 1 commit into
Open
feat: add rule for Laravel Timestamps property to attribute#491yoannblot wants to merge 1 commit into
yoannblot wants to merge 1 commit into
Conversation
peterfox
reviewed
May 11, 2026
Comment on lines
+88
to
+95
| private function isAnEloquentModelClass(Class_ $class): bool | ||
| { | ||
| if ($class->extends === null) { | ||
| return false; | ||
| } | ||
|
|
||
| return $this->isName($class->extends, 'Illuminate\Database\Eloquent\Model') || $this->isName($class->extends, 'Model'); | ||
| } |
Collaborator
There was a problem hiding this comment.
this can be replaced by a simple $this->isObjectType($class, new \PHPStan\Type\ObjectType('Illuminate\Database\Eloquent\Model')) call.
peterfox
reviewed
May 11, 2026
| } | ||
|
|
||
| $this->removePropertyFromClass($node, $timestampsProperty); | ||
| if($this->isFalseProperty($timestampsProperty)){ |
Collaborator
There was a problem hiding this comment.
Equally if you have the property you should be able to do $this->getType($timestampProperty)->isFalse()->yes() instead of needing this method implemented.
peterfox
requested changes
May 11, 2026
| return null; | ||
| } | ||
|
|
||
| $this->removePropertyFromClass($node, $timestampsProperty); |
Collaborator
There was a problem hiding this comment.
This seems wrong and should only happen if the attribute is added because the value is false. It just causes weird edge cases and extends the purepose of the rule beyond it's description.
| $rectorConfig->rule(QueuePropertyToQueueAttributeRector::class); | ||
| $rectorConfig->rule(TablePropertyToTableAttributeRector::class); | ||
| $rectorConfig->rule(TimeoutPropertyToTimeoutAttributeRector::class); | ||
| $rectorConfig->rule(TimestampsPropertyToTimestampsAttributeRector::class); |
Collaborator
There was a problem hiding this comment.
We also changed these to live in their own config instead of laravel130.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Laravel 13 introduces the WithoutTimestamps attributes (source).
Description
This new rule replaces the old property
$timestampsby the new#[WithoutTimestamps]attribute :or, removes the property when the value is true, because that's the default behavior :
use Illuminate\Database\Eloquent\Model; final class User extends Model { - public $timestamps = true; }