Skip to content

Commit 326dd4a

Browse files
committed
remove more chip related comments
1 parent 85b8ecc commit 326dd4a

6 files changed

Lines changed: 21 additions & 21 deletions

File tree

packages/design-system/src/components/ds-comments-drawer/ds-comments-drawer.stories.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -465,8 +465,8 @@ Interactive story demonstrating the filter functionality.
465465
- **Date range**: Filter by creation date
466466
- **Labels**: Filter by tags (Bug, High Priority, Feature Request, Documentation, Enhancement, Question)
467467
3. Click **Apply** to see the filtered results
468-
4. Selected filters appear as chips below the toolbar
469-
5. Click on a chip to remove that filter, or use **Clear all** to remove all filters
468+
4. Selected filters appear as tags below the toolbar
469+
5. Click on a tag to remove that filter, or use **Clear all** to remove all filters
470470
471471
**Current mock data:**
472472
- 4 unresolved comments with various authors and labels

packages/design-system/src/components/ds-select/ds-select.stories.tsx

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -256,14 +256,14 @@ export const MultiSelect: Story = {
256256
const allOption = screen.getByRole('option', { name: 'All' });
257257
await userEvent.click(allOption);
258258

259-
// Click the "+7" chip to expand and show all selected items
260-
const expandChip = screen.getByRole('button', { name: /^\+\d+$/ });
261-
await userEvent.click(expandChip);
259+
// Click the "+7" tag to expand and show all selected items
260+
const expandTag = screen.getByRole('button', { name: /^\+\d+$/ });
261+
await userEvent.click(expandTag);
262262

263-
// Verify all options from mockOptions are displayed as chips
263+
// Verify all options from mockOptions are displayed as tags
264264
for (const option of mockOptions) {
265-
const chip = screen.getByRole('button', { name: option.label });
266-
await expect(chip).toBeInTheDocument();
265+
const tag = screen.getByRole('button', { name: option.label });
266+
await expect(tag).toBeInTheDocument();
267267
}
268268

269269
// Close the dropdown by clicking the trigger
@@ -279,12 +279,12 @@ export const MultiSelect: Story = {
279279

280280
// Delete the first option by clicking its delete button
281281
const firstOption = mockOptions[0] as DsSelectOption;
282-
const firstOptionChip = screen.getByRole('button', { name: firstOption.label });
283-
const deleteButton = within(firstOptionChip).getByRole('button', { name: 'Delete tag' });
282+
const firstOptionTag = screen.getByRole('button', { name: firstOption.label });
283+
const deleteButton = within(firstOptionTag).getByRole('button', { name: 'Delete tag' });
284284
await userEvent.click(deleteButton);
285285

286286
// Verify deleted option is no longer visible
287-
await expect(firstOptionChip).not.toBeInTheDocument();
287+
await expect(firstOptionTag).not.toBeInTheDocument();
288288

289289
// Click the "Clear All" button
290290
const clearAllButton = screen.getByRole('button', { name: 'Clear All' });
@@ -454,11 +454,11 @@ export const CustomRenderOptionMultiSelect: Story = {
454454
const gbOption = screen.getByRole('option', { name: /United Kingdom/ });
455455
await userEvent.click(gbOption);
456456

457-
const usChip = screen.getByRole('button', { name: 'United States' });
458-
await expect(usChip).toBeInTheDocument();
457+
const usTag = screen.getByRole('button', { name: 'United States' });
458+
await expect(usTag).toBeInTheDocument();
459459

460-
const gbChip = screen.getByRole('button', { name: 'United Kingdom' });
461-
await expect(gbChip).toBeInTheDocument();
460+
const gbTag = screen.getByRole('button', { name: 'United Kingdom' });
461+
await expect(gbTag).toBeInTheDocument();
462462
},
463463
};
464464

packages/design-system/src/components/ds-select/ds-select.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import styles from './ds-select.module.scss';
66
import type { DsSelectOption, DsSelectProps } from './ds-select.types';
77
import { DsIcon } from '../ds-icon';
88
import { type DsCheckboxProps, DsCheckbox } from '../ds-checkbox';
9-
import { SelectItemsChips } from './select-items-chips';
9+
import { SelectItemsTags } from './select-items-tags.tsx';
1010
import { DsTypography } from '../ds-typography';
1111
import { DsTextInput } from '../ds-text-input';
1212
import { SELECT_ALL_VALUE, getUserSelectedItems } from './utils';
@@ -202,7 +202,7 @@ const DsSelect = ({
202202
)}
203203

204204
{multiselectProps.multiple && (
205-
<SelectItemsChips
205+
<SelectItemsTags
206206
onValueChange={multiselectProps.onValueChange}
207207
showAll={showAllItems}
208208
onShowAll={() => setShowAllItems(true)}

packages/design-system/src/components/ds-select/ds-select.types.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ export type DsSelectProps = {
6060
/**
6161
* Custom render function for dropdown options.
6262
* When provided, replaces the default label text inside each dropdown item.
63-
* The string `label` is still used for search, trigger text, chips, and accessibility.
63+
* The string `label` is still used for search, trigger text, tags, and accessibility.
6464
*/
6565
renderOption?: (option: DsSelectOption) => ReactNode;
6666
} & (

packages/design-system/src/components/ds-select/select-items-chips.tsx renamed to packages/design-system/src/components/ds-select/select-items-tags.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,14 +4,14 @@ import { DsButton } from '../ds-button';
44
import { DsTag } from '../ds-tag';
55
import type { DsSelectOption, SelectOptionValue } from './ds-select.types';
66

7-
type SelectItemsChipsProps = {
7+
type SelectItemsTagsProps = {
88
showAll: boolean;
99
onValueChange?: (value: SelectOptionValue[]) => void;
1010
onShowAll: () => void;
1111
count: number;
1212
};
1313

14-
export function SelectItemsChips({ showAll, onShowAll, onValueChange, count }: SelectItemsChipsProps) {
14+
export function SelectItemsTags({ showAll, onShowAll, onValueChange, count }: SelectItemsTagsProps) {
1515
const { collection, value: selectedItems } = useSelectContext() as UseSelectContext<DsSelectOption>;
1616

1717
if (!selectedItems.length) {

packages/design-system/src/components/ds-table/filters/adapters/create-checkbox-filter-adapter.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ export interface CheckboxFilterAdapterConfig<TData, TValue> {
2626
renderer?: (item: CheckboxFilterItem<TValue>) => ReactNode;
2727

2828
/**
29-
* Optional custom chip label generator
29+
* Optional custom tag label generator
3030
* @default (item) => `${label}: ${item.label}`
3131
*/
3232
tagLabelTemplate?: (item: CheckboxFilterItem<TValue>) => string;

0 commit comments

Comments
 (0)