remove more chip related comments

Author: mmurawski-dn

packages/design-system/src/components/ds-comments-drawer/ds-comments-drawer.stories.tsx

@@ -465,8 +465,8 @@ Interactive story demonstrating the filter functionality.
    - **Date range**: Filter by creation date
    - **Labels**: Filter by tags (Bug, High Priority, Feature Request, Documentation, Enhancement, Question)
 3. Click **Apply** to see the filtered results
-4. Selected filters appear as chips below the toolbar
-5. Click on a chip to remove that filter, or use **Clear all** to remove all filters
+4. Selected filters appear as tags below the toolbar
+5. Click on a tag to remove that filter, or use **Clear all** to remove all filters
 
 **Current mock data:**
 - 4 unresolved comments with various authors and labels

packages/design-system/src/components/ds-select/ds-select.stories.tsx

@@ -256,14 +256,14 @@ export const MultiSelect: Story = {
 		const allOption = screen.getByRole('option', { name: 'All' });
 		await userEvent.click(allOption);
 
-		// Click the "+7" chip to expand and show all selected items
-		const expandChip = screen.getByRole('button', { name: /^\+\d+$/ });
-		await userEvent.click(expandChip);
+		// Click the "+7" tag to expand and show all selected items
+		const expandTag = screen.getByRole('button', { name: /^\+\d+$/ });
+		await userEvent.click(expandTag);
 
-		// Verify all options from mockOptions are displayed as chips
+		// Verify all options from mockOptions are displayed as tags
 		for (const option of mockOptions) {
-			const chip = screen.getByRole('button', { name: option.label });
-			await expect(chip).toBeInTheDocument();
+			const tag = screen.getByRole('button', { name: option.label });
+			await expect(tag).toBeInTheDocument();
 		}
 
 		// Close the dropdown by clicking the trigger
@@ -279,12 +279,12 @@ export const MultiSelect: Story = {
 
 		// Delete the first option by clicking its delete button
 		const firstOption = mockOptions[0] as DsSelectOption;
-		const firstOptionChip = screen.getByRole('button', { name: firstOption.label });
-		const deleteButton = within(firstOptionChip).getByRole('button', { name: 'Delete tag' });
+		const firstOptionTag = screen.getByRole('button', { name: firstOption.label });
+		const deleteButton = within(firstOptionTag).getByRole('button', { name: 'Delete tag' });
 		await userEvent.click(deleteButton);
 
 		// Verify deleted option is no longer visible
-		await expect(firstOptionChip).not.toBeInTheDocument();
+		await expect(firstOptionTag).not.toBeInTheDocument();
 
 		// Click the "Clear All" button
 		const clearAllButton = screen.getByRole('button', { name: 'Clear All' });
@@ -454,11 +454,11 @@ export const CustomRenderOptionMultiSelect: Story = {
 		const gbOption = screen.getByRole('option', { name: /United Kingdom/ });
 		await userEvent.click(gbOption);
 
-		const usChip = screen.getByRole('button', { name: 'United States' });
-		await expect(usChip).toBeInTheDocument();
+		const usTag = screen.getByRole('button', { name: 'United States' });
+		await expect(usTag).toBeInTheDocument();
 
-		const gbChip = screen.getByRole('button', { name: 'United Kingdom' });
-		await expect(gbChip).toBeInTheDocument();
+		const gbTag = screen.getByRole('button', { name: 'United Kingdom' });
+		await expect(gbTag).toBeInTheDocument();
 	},
 };
 

packages/design-system/src/components/ds-select/ds-select.tsx

@@ -6,7 +6,7 @@ import styles from './ds-select.module.scss';
 import type { DsSelectOption, DsSelectProps } from './ds-select.types';
 import { DsIcon } from '../ds-icon';
 import { type DsCheckboxProps, DsCheckbox } from '../ds-checkbox';
-import { SelectItemsChips } from './select-items-chips';
+import { SelectItemsTags } from './select-items-tags.tsx';
 import { DsTypography } from '../ds-typography';
 import { DsTextInput } from '../ds-text-input';
 import { SELECT_ALL_VALUE, getUserSelectedItems } from './utils';
@@ -202,7 +202,7 @@ const DsSelect = ({
 						)}
 
 						{multiselectProps.multiple && (
-							<SelectItemsChips
+							<SelectItemsTags
 								onValueChange={multiselectProps.onValueChange}
 								showAll={showAllItems}
 								onShowAll={() => setShowAllItems(true)}

packages/design-system/src/components/ds-select/ds-select.types.ts

@@ -60,7 +60,7 @@ export type DsSelectProps = {
 	/**
 	 * Custom render function for dropdown options.
 	 * When provided, replaces the default label text inside each dropdown item.
-	 * The string `label` is still used for search, trigger text, chips, and accessibility.
+	 * The string `label` is still used for search, trigger text, tags, and accessibility.
 	 */
 	renderOption?: (option: DsSelectOption) => ReactNode;
 } & (

…ponents/ds-select/select-items-chips.tsx …mponents/ds-select/select-items-tags.tsxpackages/design-system/src/components/ds-select/select-items-chips.tsx renamed to packages/design-system/src/components/ds-select/select-items-tags.tsx packages/design-system/src/components/ds-select/select-items-chips.tsx renamed to packages/design-system/src/components/ds-select/select-items-tags.tsx

@@ -4,14 +4,14 @@ import { DsButton } from '../ds-button';
 import { DsTag } from '../ds-tag';
 import type { DsSelectOption, SelectOptionValue } from './ds-select.types';
 
-type SelectItemsChipsProps = {
+type SelectItemsTagsProps = {
 	showAll: boolean;
 	onValueChange?: (value: SelectOptionValue[]) => void;
 	onShowAll: () => void;
 	count: number;
 };
 
-export function SelectItemsChips({ showAll, onShowAll, onValueChange, count }: SelectItemsChipsProps) {
+export function SelectItemsTags({ showAll, onShowAll, onValueChange, count }: SelectItemsTagsProps) {
 	const { collection, value: selectedItems } = useSelectContext() as UseSelectContext<DsSelectOption>;
 
 	if (!selectedItems.length) {

packages/design-system/src/components/ds-table/filters/adapters/create-checkbox-filter-adapter.tsx

@@ -26,7 +26,7 @@ export interface CheckboxFilterAdapterConfig<TData, TValue> {
 	renderer?: (item: CheckboxFilterItem<TValue>) => ReactNode;
 
 	/**
-	 * Optional custom chip label generator
+	 * Optional custom tag label generator
 	 * @default (item) => `${label}: ${item.label}`
 	 */
 	tagLabelTemplate?: (item: CheckboxFilterItem<TValue>) => string;

packages/eslint-plugin-internal/src/rules/__tests__/consistent-deprecated-stories.test.ts

@@ -40,22 +40,6 @@ ruleTester.run('consistent-deprecated-stories', consistentDeprecatedStories, {
 			`,
 		},
 
-		{
-			name: 'inline deprecated component with correct suffix and tag',
-			code: `
-				/** @deprecated */
-				function DsChip() { return null; }
-
-				const meta = {
-					title: 'Design System/Chip (Deprecated)',
-					component: DsChip,
-					tags: ['autodocs', 'deprecated'],
-				};
-
-				export default meta;
-			`,
-		},
-
 		{
 			name: 'imported deprecated component with correct suffix and tag',
 			code: `
@@ -175,88 +159,6 @@ ruleTester.run('consistent-deprecated-stories', consistentDeprecatedStories, {
 	],
 
 	invalid: [
-		{
-			name: 'missing both suffix and tags prop - fixes both',
-			code: `
-				/** @deprecated */
-				function DsChip() { return null; }
-
-				const meta = {
-					title: 'Design System/Chip',
-					component: DsChip,
-				};
-
-				export default meta;
-			`,
-			output: `
-				/** @deprecated */
-				function DsChip() { return null; }
-
-				const meta = {
-					title: 'Design System/Chip (Deprecated)',
-					component: DsChip,\n\ttags: ['deprecated'],
-				};
-
-				export default meta;
-			`,
-			errors: [
-				{
-					messageId: 'missingDeprecatedTag',
-					data: { component: 'DsChip' },
-					line: 5,
-					column: 18,
-					endLine: 8,
-					endColumn: 6,
-				},
-				{
-					messageId: 'missingDeprecatedSuffix',
-					data: { component: 'DsChip' },
-					line: 6,
-					column: 13,
-					endLine: 6,
-					endColumn: 33,
-				},
-			],
-		},
-
-		{
-			name: 'has suffix but missing tag - appends to existing tags',
-			code: `
-				/** @deprecated */
-				function DsChip() { return null; }
-
-				const meta = {
-					title: 'Design System/Chip (Deprecated)',
-					component: DsChip,
-					tags: ['autodocs'],
-				};
-
-				export default meta;
-			`,
-			output: `
-				/** @deprecated */
-				function DsChip() { return null; }
-
-				const meta = {
-					title: 'Design System/Chip (Deprecated)',
-					component: DsChip,
-					tags: ['autodocs', 'deprecated'],
-				};
-
-				export default meta;
-			`,
-			errors: [
-				{
-					messageId: 'missingDeprecatedTag',
-					data: { component: 'DsChip' },
-					line: 8,
-					column: 6,
-					endLine: 8,
-					endColumn: 24,
-				},
-			],
-		},
-
 		{
 			name: 'has tag but missing label - appends suffix',
 			code: `
@@ -342,82 +244,6 @@ ruleTester.run('consistent-deprecated-stories', consistentDeprecatedStories, {
 			],
 		},
 
-		{
-			name: 'suffix in the middle - moves suffix to the end',
-			code: `
-				/** @deprecated */
-				function DsChip() { return null; }
-
-				const meta = {
-					title: 'Design System/Chip (Deprecated) Old',
-					component: DsChip,
-					tags: ['deprecated'],
-				};
-
-				export default meta;
-			`,
-			output: `
-				/** @deprecated */
-				function DsChip() { return null; }
-
-				const meta = {
-					title: 'Design System/Chip Old (Deprecated)',
-					component: DsChip,
-					tags: ['deprecated'],
-				};
-
-				export default meta;
-			`,
-			errors: [
-				{
-					messageId: 'missingDeprecatedSuffix',
-					data: { component: 'DsChip' },
-					line: 6,
-					column: 13,
-					endLine: 6,
-					endColumn: 50,
-				},
-			],
-		},
-
-		{
-			name: 'suffix has multiple spaces - removes extra spaces',
-			code: `
-				/** @deprecated */
-				function DsChip() { return null; }
-
-				const meta = {
-					title: 'Design System/Chip    (Deprecated)',
-					component: DsChip,
-					tags: ['deprecated'],
-				};
-
-				export default meta;
-			`,
-			output: `
-				/** @deprecated */
-				function DsChip() { return null; }
-
-				const meta = {
-					title: 'Design System/Chip (Deprecated)',
-					component: DsChip,
-					tags: ['deprecated'],
-				};
-
-				export default meta;
-			`,
-			errors: [
-				{
-					messageId: 'unformattedDeprecatedSuffix',
-					data: { component: 'DsChip' },
-					line: 6,
-					column: 13,
-					endLine: 6,
-					endColumn: 49,
-				},
-			],
-		},
-
 		{
 			name: 'inline default export without suffix and tags prop - fixes both',
 			code: `