feat(design-system): add wizard/stepper enchantments, draggable panel [AR-44336]#137
Conversation
mmurawski-dn
force-pushed
the
drivenets/michal/AR-44336-wizard-stepper
branch
from
25b2ad1 to
18be852
Compare
mmurawski-dn
force-pushed
the
drivenets/michal/AR-44336-wizard-stepper
branch
from
18be852 to
c8d6d4e
Compare
…:mmurawski-dn/design-system into drivenets/michal/AR-44336-wizard-stepper
| import { DsIcon } from '../ds-icon'; | ||
| import type { DsPanelCollapseButtonProps, DsPanelProps } from './ds-panel.types'; | ||
|
|
||
| function useDraggable(enabled: boolean) { |
There was a problem hiding this comment.
There was a problem hiding this comment.
To be fair, I did not see that one :O hmm, not sure what's better. Here, we just add one hook and call it a day; ARK has the built-in component, but it will be more to revamp, cause the current one uses radix, right? 🤔
Maybe a ticket to migrate to the floating panel from ark-ui? WDYT @StyleShit
There was a problem hiding this comment.
Ouch, this is an elephant in the room 😅
We’re a bit tight on time here. We already said this component is ready and we’re planning to show it in tomorrow’s demo.
I’m +1 on Michal’s idea — let’s merge it as is and open a ticket to migrate it to ark-ui afterward.
We have a call with Inbal in ~40 mins, so we can double-check with her then if that works.
| const childArray = React.Children.toArray(children); | ||
| const steps = childArray.filter((child) => React.isValidElement(child) && child.type === DsStep); | ||
| const actions = childArray.filter((child) => !(React.isValidElement(child) && child.type === DsStep)); |
There was a problem hiding this comment.
feels overkill
why do we need this? can't we just trust that the users will pass the components properly?
| onComplete?: steps.Props['onStepComplete']; | ||
| activeStep?: steps.Props['step']; | ||
| className?: string; | ||
| actions?: ReactNode; |
There was a problem hiding this comment.
what's the difference between these actions and the StepperContent actions?
There was a problem hiding this comment.
Wrong naming, those are horizontalActions only
…ets/michal/AR-44336-wizard-stepper
…:mmurawski-dn/design-system into drivenets/michal/AR-44336-wizard-stepper
4 participants
https://drivenets.atlassian.net/browse/AR-44128
screen-capture.6.webm