Add optional chaining to prototype check in is()

Object.getPrototypeOf() returns null for objects created with Object.create(null). Without optional chaining, accessing .constructor on null throws a TypeError. This affects insert and update operations when a user passes an Object.create(null)-based value (e.g. for a JSON column), since the query builder calls is(colValue, SQL) on each value.

Author: markacola

drizzle-orm/src/entity.ts

@@ -26,7 +26,7 @@ export function is<T extends DrizzleEntityClass<any>>(value: any, type: T): valu
 		);
 	}
 
-	let cls = Object.getPrototypeOf(value).constructor;
+	let cls = Object.getPrototypeOf(value)?.constructor;
 	if (cls) {
 		// Traverse the prototype chain to find the entityKind
 		while (cls) {

drizzle-orm/tests/is.test.ts

@@ -1,16 +1,56 @@
+import postgres from 'postgres';
 import { describe, test } from 'vitest';
-import { Column, is } from '~/index.ts';
-import { PgArray, PgColumn, PgSerial, pgTable, serial } from '~/pg-core/index.ts';
+import { Column, is, SQL } from '~/index.ts';
+import { jsonb, PgArray, PgColumn, PgSerial, pgTable, serial, text } from '~/pg-core/index.ts';
+import { drizzle } from '~/postgres-js/index.ts';
+import { eq } from '~/sql/index.ts';
 
 const pgExampleTable = pgTable('test', {
 	a: serial('a').array(),
 });
 
+const nullProtoTable = pgTable('null_proto_test', {
+	id: serial('id').primaryKey(),
+	name: text('name').notNull(),
+	data: jsonb('data'),
+});
+
+const db = drizzle(postgres(''));
+
 describe.concurrent('is', () => {
 	test('Column', ({ expect }) => {
 		expect(is(pgExampleTable.a, Column)).toBe(true);
 		expect(is(pgExampleTable.a, PgColumn)).toBe(true);
 		expect(is(pgExampleTable.a, PgArray)).toBe(true);
 		expect(is(pgExampleTable.a, PgSerial)).toBe(false);
 	});
+
+	test('Object.create(null) value does not throw', ({ expect }) => {
+		const nullProtoValue = Object.create(null);
+		expect(is(nullProtoValue, SQL)).toBe(false);
+		expect(is(nullProtoValue, Column)).toBe(false);
+	});
+
+	test('insert with Object.create(null) value', ({ expect }) => {
+		const jsonValue = Object.create(null);
+		jsonValue.key = 'value';
+
+		const query = db
+			.insert(nullProtoTable)
+			.values({ name: 'test', data: jsonValue });
+
+		expect(query.toSQL()).toBeTruthy();
+	});
+
+	test('update with Object.create(null) value', ({ expect }) => {
+		const jsonValue = Object.create(null);
+		jsonValue.key = 'value';
+
+		const query = db
+			.update(nullProtoTable)
+			.set({ data: jsonValue })
+			.where(eq(nullProtoTable.id, 1));
+
+		expect(query.toSQL()).toBeTruthy();
+	});
 });