Feat: MsSql support by Angelelz · Pull Request #1610 · drizzle-team/drizzle-orm

Angelelz · 2023-12-06T07:16:26Z

This PR aims to close #585.

The initial implementation and the first couple of tests are implemented. I will update this description with the status of the implementation.
Initially the only supported driver will be node-mssql.
There is still a lot to do:

AndriiSherman · 2023-12-07T13:06:03Z

@Angelelz I guess we should not include RQB in first iteration for MSSQL. So it can be another PR scope, same as Merge support (to do upsert type of functionality)

Irupt · 2023-12-07T16:53:46Z

Hello, Thank you for the time you devote to this dialect. I can not wait to see him :)
I looked at some commits, and I wanted to tell you that ntext and text are deprecated and soon deleted: should be replaced by nvarchar(max) varchar(max). These two types are compatible since SQL Server 2012.
Likewise "max" (string) is an acceptable value for "length" of these column types.

Angelelz · 2023-12-09T04:49:39Z

No idea why the tests are not passing. They run well locally. Any idea @dankochetov ?

Angelelz · 2023-12-12T02:49:20Z

Some features have been postponed to later PRs, the scope of this one is already huge as it is.
Here are some notable ones:

Merge clause (to do upserts)
Output clause (similar to returning)
Select top similar to limit
Recursive CTE ergonomics

…columns

…ql does that for us

Angelelz · 2024-10-27T04:00:13Z

The PR has been updated to resolve conflicts and use the new structures/features of the library.
But there is still some work to do: notably, the new syntax to define columns without the database column name is not implemented. @AndriiSherman Should I implement that feature for this PR or you would prefer to include that feature at a later date?

Gideon-Felt · 2024-12-17T22:28:29Z

Is no one going to respond to @Angelelz? next steps are needed.

Aaqu · 2024-12-23T12:32:06Z

Is no one going to respond to @Angelelz? next steps are needed.

In my opinion, they are waiting, hoping that a sponsor might come forward. Right now, it’s not profitable for them.

Angelelz · 2024-12-23T15:45:14Z

Just to put this out there. This is a 40k+ line PR, and this is only half of what is needed to support mssql. The team will do its best but remember that drizzle-kit support will be needed before this is merged. This PR is only for the ORM side. Mssql requires new syntax to introspect, generate migrations, support the studio, and other drizzle-kit stuff. My understanding is that the team will take care of that part.

opensas · 2024-12-23T18:47:36Z

Just to put this out there. This is a 40k+ line PR, and this is only half of what is needed to support mssql. The team will do its best but remember that drizzle-kit support will be needed before this is merged. This PR is only for the ORM side. Mssql requires new syntax to introspect, generate migrations, support the studio, and other drizzle-kit stuff. My understanding is that the team will take care of that part.

great, thanks a lot for all this effort

it would be great to have an issue with the remaining tasks, so we can track it, and it would help everybody understand what's still missing

…mssql-support

mfferreira · 2025-03-26T14:41:00Z

Any progress on this?

- Added default handling for drizzle-kit - Changed config type for mssql tables

Removed: - smalldate and mediumint columns Added: - snake_case and camelCase to config Updated: - table config and some columns configs. No need to pass names to columns - View config

Fixed dprint issues Commented mssql dialect in drizzle-kit

Updated: - tests (added names to constraints) - made constraint names mandatory for mssql > Mssql generates names with custom hash - top, offset and fetch are now accept placeholder Added: - drizzle mock - new tests for top, offset and fetch Also commented mssql logic in drizzle-kit as it is not supported yet

…to feat-mssql-support

+	console.log(wrapParam('host', options.host));
+	console.log(wrapParam('port', options.port, true));
+	console.log(wrapParam('user', options.user, true));
+	console.log(wrapParam('password', options.password, true, 'secret'));


+
+		statement += it.generated
+			? `.generatedAlwaysAs(sql\`${
+				it.generated.as.replace(


+		statement += `\n\t`;
+		statement += 'check(';
+		statement += `"${it.name}", `;
+		statement += `sql\`${it.value.replace(/`/g, '\\`')}\`)`;


…to feat-mssql-support

Updated tests

…to feat-mssql-support

Gideon-Felt · 2025-05-19T20:25:47Z

great, thanks a lot for all this effort

it would be great to have an issue with the remaining tasks, so we can track it, and it would help everybody understand what's still missing

@Angelelz wondering if you saw this? I think they want more visibility on this, I know that would certainly get more eyes on it at least. (and make it easier to delegate remaining work for anyone who want's to also help).

mfferreira · 2025-06-10T12:19:00Z

Can't wait to use this!

benalexb · 2025-08-06T11:58:54Z

Can we please merge this? 🙏🏻 we have all been waiting a long time for this fix. What is blocking it?

Aaqu · 2025-08-12T11:29:03Z

@AndriiSherman any news on mssql? ❤️

Aaqu · 2025-10-03T08:47:36Z

There is a new version of node-mssql 12.0.0, will it be compatible?

github-advanced-security AI found potential problems Dec 6, 2023

View reviewed changes

Comment thread integration-tests/tests/mssql.test.ts Fixed

Angelelz marked this pull request as ready for review December 12, 2023 02:24

AndriiSherman self-requested a review December 15, 2023 12:19

AndriiSherman changed the base branch from main to beta December 15, 2023 12:19

Angelelz added 22 commits December 26, 2023 21:53

[MsSql] initial implementation

d5f2f38

[MsSql] deleted deprecated methods and functions and fixed types for …

2408d08

…columns

[MsSql] Delete serial data type and added identity to number data types

322d93e

[MsSql] Added mssql and @types/mssql to integration tests package

6b82886

[MsSql] Removed intersectAll and exceptAll

bfe701a

[MsSql] Added a way to not insert default on identity columns

a276cd6

[MsSql][teporary] made json column be a text

fa066f0

[MsSql] datetime columns don't need to be mapped to a Date object mss…

e460cae

…ql does that for us

[MsSql] fix offset and fetch in select and allow insert default values

cc17337

[MsSql] Fix save transaction syntax

8a78552

[MsSql] Added limit and offset to select

30e8388

[MsSql] deleted not supported onDuplicateKey

4537f30

[MsSql] Removed unsopported ignore in insert

ae1ee89

[MsSql] Fixed syntax in migrate function

1e21efe

[MsSql] Fixed integer columns and deleted not used types

5eb62fb

[MsSql] Created but data type

a584000

[MsSql] Fixed string data types

abb7dc4

[MsSql] fixed time data types

7b0d51d

[MsSql] Added initial batch of integration tests

d6e9aa0

[MsSql] Made config for char and varchar optional

b828b7f

[MsSql] Added dialect support for top and for clauses in the select

08dea00

[MsSql] [feat] Added RQB support

d8c6ce3

AndriiSherman added 2 commits January 9, 2025 17:15

Merge branch 'beta' of github.com:drizzle-team/drizzle-orm into feat-…

ec26cc8

…mssql-support

Fix build error

97273ad

ProvorovOleksii and others added 6 commits April 16, 2025 13:38

Updated:

2b4d71a

- Added default handling for drizzle-kit - Changed config type for mssql tables

merge main to feat-mssql-support

ce6270c

casing + data types + joins tests

9672402

Removed: - smalldate and mediumint columns Added: - snake_case and camelCase to config Updated: - table config and some columns configs. No need to pass names to columns - View config

Fixed type errors in test for mssql

ed3317f

Fixed dprint issues Commented mssql dialect in drizzle-kit

WIP limit offset

9c08781

WIP limit offset

99d6b2b

AleksandrSherman changed the base branch from beta to main April 24, 2025 09:20

AleksandrSherman added 2 commits April 24, 2025 12:22

Merge branch 'main' of https://github.com/drizzle-team/drizzle-orm in…

2ddac33

…to feat-mssql-support

github-advanced-security AI found potential problems Apr 24, 2025

View reviewed changes

AleksandrSherman added 7 commits April 24, 2025 16:00

[mssql]: fixed tests

66b0a84

[mssql]: fixed deps

57a3967

Merge branch 'main' of https://github.com/drizzle-team/drizzle-orm in…

e653aa9

…to feat-mssql-support

[mssql] constraint names are not mandatory now

96704d0

Updated tests

[mssql] commented drizzle-kit logic

4431f64

Merge branch 'main' of https://github.com/drizzle-team/drizzle-orm in…

7040e8e

…to feat-mssql-support

[mssql]: fixed imports

47c6ad4

Uh oh!

Conversation

Angelelz commented Dec 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

AndriiSherman commented Dec 7, 2023

Uh oh!

Irupt commented Dec 7, 2023

Uh oh!

Angelelz commented Dec 9, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Angelelz commented Dec 12, 2023

Uh oh!

Angelelz commented Oct 27, 2024

Uh oh!

Gideon-Felt commented Dec 17, 2024

Uh oh!

Aaqu commented Dec 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Angelelz commented Dec 23, 2024

Uh oh!

opensas commented Dec 23, 2024

Uh oh!

mfferreira commented Mar 26, 2025

Uh oh!

Check failure

Uh oh!

Check failure

Check failure

Gideon-Felt commented May 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mfferreira commented Jun 10, 2025

Uh oh!

benalexb commented Aug 6, 2025

Uh oh!

Aaqu commented Aug 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Aaqu commented Oct 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

Angelelz commented Dec 6, 2023 •

edited

Loading

Angelelz commented Dec 9, 2023 •

edited

Loading

Aaqu commented Dec 23, 2024 •

edited

Loading

Gideon-Felt commented May 19, 2025 •

edited

Loading

Aaqu commented Aug 12, 2025 •

edited

Loading

Aaqu commented Oct 3, 2025 •

edited

Loading