[Pg] Add Temporal mapping support#4475
Open
XiNiHa wants to merge 3 commits intodrizzle-team:mainfrom
Open
Conversation
|
@XiNiHa Hey! This PR has conflicts now. 😅 Could you rebase when you get a chance? The maintainers have been silent, but maybe resolving conflicts will help get their attention! |
Author
|
Sure! I'll make it done until tomorrow 😋 |
|
I picked this up and rebased it onto the latest main. I also added test coverage, wired in the Temporal polyfill for Vitest, and adjusted the interval handling (removed the fallback due to unsafe parsing behavior with certain PostgreSQL interval formats). New PR here for continuation/review: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #1776
jiff(Temporal-like datetime library in Rust) integration forsqlx: Support jiff as a date time lib backend launchbadge/sqlx#3487timestamp=>PlainDateTimetimestamptz=>Instantdate=>PlainDatetime=>PlainTimeinterval=>Durationpostgres-intervaldependency, but I'm not sure about the license issues. Some help would be appreciated.ColumnDataTypeis used for, therefore I didn't add any Temporal types there and just used'date's. Let me know if it should be added.