fix(types): relax type constraints broken by stripInternal#5409
Open
YevheniiKotyrlo wants to merge 1 commit intodrizzle-team:mainfrom
Open
fix(types): relax type constraints broken by stripInternal#5409YevheniiKotyrlo wants to merge 1 commit intodrizzle-team:mainfrom
YevheniiKotyrlo wants to merge 1 commit intodrizzle-team:mainfrom
Conversation
be514a2 to
bfeec12
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two fixes for type declarations that become invalid after
@internalproperties are stripped from.d.tsoutput bystripInternal: true:1. Relax
SelectWithoutgeneric constraint (3 files)K extends keyof T & string→K extends stringin:src/mysql-core/query-builders/select.types.tssrc/singlestore-core/query-builders/select.types.tssrc/sqlite-core/query-builders/select.types.tsThe constraint fails because set operator excluded method lists include
'session'— a property marked@internaland stripped from.d.ts. When'session'is absent from the emitted type,'session'no longer satisfieskeyof T & string.Omit<>already handles missing keys safely (they're simply ignored), soK extends stringis sufficient.2. Remove
implementsclause from Policy classes (2 files)PgPolicy implements PgPolicyConfig→PgPolicyin:src/pg-core/policies.tssrc/gel-core/policies.tsThe config interfaces have optional properties (
as?,for?), but the class declares them as non-optional readonly. After@internalstripping, theimplementsclause produces TS2420 because the structural match fails. The class remains structurally compatible without the clause — removing it eliminates the false type error without changing behavior.Related: #5187, #4299