Skip to content

docs: fix typos in markdown documentation#5562

Open
Goldyvaiiii wants to merge 2 commits intodrizzle-team:mainfrom
Goldyvaiiii:main
Open

docs: fix typos in markdown documentation#5562
Goldyvaiiii wants to merge 2 commits intodrizzle-team:mainfrom
Goldyvaiiii:main

Conversation

@Goldyvaiiii
Copy link
Copy Markdown

This PR fixes a few minor typographical errors in the markdown documentation (README, etc.) to improve readability. Found via codespell.

// Refining the fields - useful if you want to change the fields before they become nullable/optional in the final schema
const insertUserSchema = createInsertSchema(users, {
id: (schema) => schema.atLeast(1),
id: (schema) => schema.at least(1),
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The atLeast is a part of the arktype code and is not a typo

Comment thread drizzle-arktype/README.md
// Refining the fields - useful if you want to change the fields before they become nullable/optional in the final schema
const insertUserSchema = createInsertSchema(users, {
id: (schema) => schema.atLeast(1),
id: (schema) => schema.at least(1),
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here:
The atLeast is a part of the arktype code and is not a typo

Copy link
Copy Markdown

@Pspsps12 Pspsps12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert the changes that affect the code and are not actually a typo pointed out in my comments

* Unix time at which the key will expire, in seconds (a positive integer).
*/
exat?: number;
exact?: number;
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, part of the code and is valid. exat stands for "expire at"

### Bug fixes

- Fixed `algorythm` => `algorithm` typo.
- Fixed `algorithm` => `algorithm` typo.
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is intentional to point out the fixes in that release

- Fixed pg-native Pool detection in node-postgres transactions
- Allowed subqueries in select fields
- Updated typo algorythm => algorithm
- Updated typo algorithm => algorithm
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here:
This is intentional to point out the fixes in that release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants