fix: pass 'indexes' invokeSource for MSSQL filtered index WHERE clause#5596
Open
funsaized wants to merge 1 commit intodrizzle-team:betafrom
Open
fix: pass 'indexes' invokeSource for MSSQL filtered index WHERE clause#5596funsaized wants to merge 1 commit intodrizzle-team:betafrom
funsaized wants to merge 1 commit intodrizzle-team:betafrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #5593
When defining a filtered unique index with
where(isNotNull(...))for SQL Server, drizzle-kit generates a fully qualified column name (e.g.,[schema].[table].[column]) inside theWHEREclause, which SQL Server rejects for filtered indexes.Root Cause
In
drizzle-kit/src/dialects/mssql/drizzle.ts, thewhereclause for indexes was serialized without passing the'indexes'invokeSource todialect.sqlToQuery():Without
'indexes', column references in the WHERE clause get fully qualified as[schema].[table].[column]. The core SQL serializer indrizzle-orm/src/sql/sql.tsalready has handling forinvokeSource === 'indexes'— when set, it returns just the column name[column], which is valid T-SQL for filtered indexes.This matches how the Postgres dialect already handles index WHERE clauses (passing
'indexes'tosqlToQuery).Changes
drizzle-kit/src/dialects/mssql/drizzle.ts: Pass'indexes'asinvokeSourcewhen serializing the WHERE clausedrizzle-kit/tests/mssql/indexes.test.ts: Update test expectations to match the unqualified column namesdrizzle-kit/tests/mssql/tables.test.ts: Update test expectations to match the unqualified column namesBefore / After
Before (invalid T-SQL):
After (valid T-SQL):