fix: allow not() to accept return types of and() and or()#5654
Open
yosofbadr wants to merge 1 commit intodrizzle-team:mainfrom
Open
fix: allow not() to accept return types of and() and or()#5654yosofbadr wants to merge 1 commit intodrizzle-team:mainfrom
yosofbadr wants to merge 1 commit intodrizzle-team:mainfrom
Conversation
The not() function previously only accepted SQLWrapper, but and() and or() return SQL | undefined. This caused a type error when composing not(and(...)) or not(or(...)). Updated not() to accept SQLWrapper | undefined and return SQL | undefined, returning undefined when passed undefined for consistency with and() and or(). Fixes drizzle-team#1818
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
not()function type signature to acceptSQLWrapper | undefined(instead of justSQLWrapper) and returnSQL | undefined(instead of justSQL)undefinedis passed (e.g. fromand()oror()returningundefined),not()now returnsundefinedinstead of producing a type errornot()composable withand()andor()without requiring type assertionsProblem
and()andor()returnSQL | undefined, butnot()only acceptedSQLWrapper. This caused a TypeScript error when composing them:Fixes #1818
Test plan
not(and(...))compiles without type errorsnot(or(...))compiles without type errorsnot(undefined)returnsundefinednot(someCondition)still returnsSQLas before when given a defined condition