fix(node-postgres): release pool client when transaction BEGIN rejects#6030
Open
xianjianlf2 wants to merge 1 commit into
Open
Conversation
Move the BEGIN statement inside the try/finally that releases the checked-out pool client. Previously, if BEGIN rejected (e.g. the connection was interrupted right after checkout), control never reached the finally block, so the client was never returned to the pool and repeated failures could exhaust it. ROLLBACK is still only issued after BEGIN has succeeded. Closes drizzle-team#6023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
With the node-postgres driver, a transaction whose
BEGINstatement rejects (e.g. the connection dies right after checkout, or a server-side error) leaks the checked-out pool client: innode-postgres/session.ts,await tx.execute(sql\begin...`)runs *before* thetry/finallywhosefinallyreleases the client, so a rejectingBEGINskipsrelease()` entirely. Under load this exhausts the pool.Closes #6023
Fix
Move the
BEGINinside the outertry/finallyso the client is always released, while keepingROLLBACKgated onBEGINhaving succeeded (no rollback is attempted for a transaction that never started).Testing
New DB-free
tests/node-postgres-transaction.test.tswith a mock pool:BEGINrejects → client released exactly once and noROLLBACKissued (red before the fix:released: 0); commit path unchanged; callback throwing →ROLLBACK+ release. Full drizzle-orm unit suite: 14 files, 569/569 passing;tsc --noEmitanddprint checkclean.