Fix unused variable warnings#2385
Merged
an-tao merged 1 commit intodrogonframework:masterfrom Dec 25, 2025
Merged
Conversation
e5da694 to
fab2b47
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR fixes compiler warnings related to unused variables and mismatched class/struct declarations in the Drogon framework. The changes remove dead code and improve type safety by eliminating variables that were declared but never used.
- Removes unused variable declarations that were causing compiler warnings
- Fixes class/struct declaration mismatches for consistency
- Adds proper type casting to prevent implicit conversion warnings
- Removes commented-out dead code
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| lib/src/Utilities.cc | Removes unused seconds variable and adds namespace comment |
| lib/src/SlidingWindowRateLimiter.cc | Removes unused startTime variable |
| lib/src/HttpResponseImpl.cc | Removes unused contentType variables and commented code |
| lib/src/HttpControllersRouter.h | Changes class declaration to struct for consistency |
| lib/src/HttpClientImpl.cc | Removes unused type variable |
| lib/inc/drogon/HttpViewData.h | Adds explicit type casting to prevent warnings |
| lib/inc/drogon/HttpResponse.h | Removes unused parameter name in template function |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the following warnings: