mysql exception forward errorNo to SqlError#2427
Merged
an-tao merged 3 commits intodrogonframework:masterfrom Dec 25, 2025
Merged
mysql exception forward errorNo to SqlError#2427an-tao merged 3 commits intodrogonframework:masterfrom
an-tao merged 3 commits intodrogonframework:masterfrom
Conversation
mysql_errno is not forwarded to SqlError
There was a problem hiding this comment.
Pull request overview
This PR forwards the MySQL error number to the SqlError exception constructor, addressing the issue that mysql_errno was not previously being passed to the SqlError object. This allows error codes to be accessible from caught exceptions.
- Updates the SqlError constructor call to include the MySQL error number
- Switches from the 3-parameter constructor (with sqlstate) to the 4-parameter constructor (with error codes)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Till know mysql_errno is not forwarded . I've added the value to SqlError constructor.