Skip to content

A simple fix #2500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fe-dagostino wants to merge 3 commits into
base: master
Choose a base branch
from
Open

A simple fix #2500

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4839831
Update UploadFile.h
fe-dagostino Apr 10, 2026
86646f9
Merge branch 'drogonframework:master' into master
fe-dagostino Apr 21, 2026
18e7cb9
Fix return statement in SqlBinder.h for callbacks
fe-dagostino Apr 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions orm_lib/inc/drogon/orm/SqlBinder.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -361,22 +361,22 @@ class DROGON_EXPORT SqlBinder : public trantor::NonCopyable
// LOG_DEBUG << "ptr callback";
isExceptionPtr_ = true;
exceptionPtrCallback_ = std::forward<CallbackType>(callback);
return *this;
}
else
{
isExceptionPtr_ = false;
exceptionCallback_ = std::forward<CallbackType>(callback);
return *this;
}
}
else if constexpr (traits::isSqlCallback)

if constexpr (traits::isSqlCallback)
{
callbackHolder_ = std::shared_ptr<CallbackHolderBase>(
new CallbackHolder<typename std::decay<CallbackType>::type>(
std::forward<CallbackType>(callback)));
return *this;
}

return *this;
}

template <typename T>
Expand Down
Loading