Use caller-supplied HttpClient for token refresh (#324)#379
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #379 +/- ##
==========================================
+ Coverage 53.81% 54.09% +0.28%
==========================================
Files 16 16
Lines 1403 1403
Branches 134 134
==========================================
+ Hits 755 759 +4
+ Misses 608 604 -4
Partials 40 40
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
AndreyVMarkelov
force-pushed
the
fix/324-refresh-httpclient
branch
from
a251eec to
2c2d816
Compare
RefreshAccessToken sent the OAuth token request through the SDK's internal default HttpClient, ignoring a caller-supplied client. In high-traffic apps this leaked connections and exhausted ports. Route the refresh through GetHttpClient(HostType.Api) like normal requests, and add a regression test asserting the refresh uses the supplied client.
AndreyVMarkelov
force-pushed
the
fix/324-refresh-httpclient
branch
from
2c2d816 to
bcdd4e0
Compare
rhui-dbx
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #324.
RefreshAccessToken sent the OAuth token request through the SDK's internal default HttpClient, ignoring a caller-supplied client. In high-traffic apps this leaked connections and exhausted ports.