Skip to content

Fix OAuthPKCE example browser launch on .NET Core (#334)#380

Merged
AndreyVMarkelov merged 1 commit into
mainfrom
fix/334-pkce-process-start
Jul 7, 2026
Merged

Fix OAuthPKCE example browser launch on .NET Core (#334)#380
AndreyVMarkelov merged 1 commit into
mainfrom
fix/334-pkce-process-start

Conversation

@AndreyVMarkelov

Copy link
Copy Markdown
Contributor

Fixes #334.

Process.Start(url) throws on .NET Core because UseShellExecute defaults to false. Pass a ProcessStartInfo with UseShellExecute = true so the URL opens in the default browser.

Process.Start(url) throws on .NET Core because UseShellExecute defaults
to false. Pass a ProcessStartInfo with UseShellExecute = true so the URL
opens in the default browser.
@codecov

codecov Bot commented Jul 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 53.81%. Comparing base (cde11d5) to head (01ba290).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #380   +/-   ##
=======================================
  Coverage   53.81%   53.81%           
=======================================
  Files          16       16           
  Lines        1403     1403           
  Branches      134      134           
=======================================
  Hits          755      755           
  Misses        608      608           
  Partials       40       40           
Flag Coverage Δ
integration 50.32% <ø> (ø)
unit 10.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@AndreyVMarkelov AndreyVMarkelov merged commit 62b19d7 into main Jul 7, 2026
13 checks passed
@AndreyVMarkelov AndreyVMarkelov deleted the fix/334-pkce-process-start branch July 7, 2026 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OAuth PKCE getting access token is not working

2 participants