Skip to content

Return state from ProcessCodeFlowAsync (#248)#381

Merged
AndreyVMarkelov merged 1 commit into
mainfrom
fix/248-processcodeflow-state
Jul 8, 2026
Merged

Return state from ProcessCodeFlowAsync (#248)#381
AndreyVMarkelov merged 1 commit into
mainfrom
fix/248-processcodeflow-state

Conversation

@AndreyVMarkelov

Copy link
Copy Markdown
Contributor

Fixes #248.

The Uri overload of ProcessCodeFlowAsync validated the state parameter but never returned it, so OAuth2Response.State was always null. Thread state through to the inner overload and into the response.

Added a test that reproduces the null state and passes with the fix.

The Uri overload validated the state parameter but never returned it, so
OAuth2Response.State was always null. Thread state through to the inner
overload and into the response. Add a test.
@codecov

codecov Bot commented Jul 7, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 58.30%. Comparing base (c25d774) to head (da8c0f5).

Files with missing lines Patch % Lines
...pbox-sdk-dotnet/Dropbox.Api/DropboxOauth2Helper.cs 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #381      +/-   ##
==========================================
+ Coverage   54.09%   58.30%   +4.20%     
==========================================
  Files          16       16              
  Lines        1403     1403              
  Branches      134      134              
==========================================
+ Hits          759      818      +59     
+ Misses        604      524      -80     
- Partials       40       61      +21     
Flag Coverage Δ
integration 54.81% <66.66%> (+4.20%) ⬆️
unit 10.54% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@AndreyVMarkelov AndreyVMarkelov merged commit a96febc into main Jul 8, 2026
13 checks passed
@AndreyVMarkelov AndreyVMarkelov deleted the fix/248-processcodeflow-state branch July 8, 2026 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DropboxOAuth2Helper.ProcessCodeFlowAsync()'s state parameter is lost/ignored

2 participants