Add DisposeUploadStream option to keep upload stream open (#340)#382
Merged
Conversation
UploadAsync always disposed the caller's stream. Add DropboxClientConfig.DisposeUploadStream (default true, preserving current behavior); set false to keep the stream open. Add tests for both modes.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #382 +/- ##
==========================================
+ Coverage 54.09% 54.35% +0.26%
==========================================
Files 16 16
Lines 1403 1411 +8
Branches 134 135 +1
==========================================
+ Hits 759 767 +8
Misses 604 604
Partials 40 40
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
cguldner
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #340.
UploadAsync always disposed the caller's stream as a hidden side effect. Added DropboxClientConfig.DisposeUploadStream (default true, so existing behavior is unchanged); set it to false to keep the stream open after upload.
Non-breaking: only touches hand-written files, no interface or generated-code changes.
Tests: one asserts the default still disposes, one asserts the stream stays open when the option is false (reproduced the ObjectDisposedException before the fix).