Remove unused Dropbox.Api.nuspec#387
Open
AndreyVMarkelov wants to merge 1 commit into
Open
Conversation
dotnet pack builds the package from the SDK-style csproj, not this nuspec. Nothing references it, and its Newtonsoft.Json dependency (7.0.1/10.0.3) was stale versus the csproj (13.0.2). Verified the packed nupkg declares Newtonsoft.Json 13.0.2 after removal.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #387 +/- ##
=======================================
Coverage 61.60% 61.60%
=======================================
Files 17 17
Lines 1654 1654
Branches 155 155
=======================================
Hits 1019 1019
Misses 565 565
Partials 70 70
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The package is built by
dotnet packfrom the SDK-style csproj, not this nuspec. Nothing in the repo references it (no workflow, script, or csproj), and its declared Newtonsoft.Json dependency (7.0.1 / 10.0.3) was stale versus the csproj (13.0.2).Verified: after removal,
dotnet pack -p:Version=7.2.0succeeds and the produced nupkg correctly declares Newtonsoft.Json 13.0.2.