Skip to content

Commit 43957ab

Browse files
aaronskyaaronsky
authored
Remove secrets from GitHub Actions (#394)
* Remove secrets from GitHub Actions Per internal discussions, we are removing secure strings from GitHub Actions to align with our internal secret management policies. This changes the CI to build-only mode for the tests. Given this repo is effectively frozen, we'll have to make do with the minimal verification case. * Update ci.yml
1 parent 8fb0516 commit 43957ab

3 files changed

Lines changed: 5 additions & 121 deletions

File tree

‎.github/workflows/ci.yml‎

Lines changed: 5 additions & 37 deletions
Original file line numberDiff line numberDiff line change
@@ -16,48 +16,16 @@ jobs:
1616
pod install --repo-update
1717
- name: Test iOS
1818
env:
19-
FULL_DROPBOX_API_APP_KEY: ${{ secrets.FULL_DROPBOX_API_APP_KEY }}
20-
FULL_DROPBOX_TESTER_TEAM_REFRESH_TOKEN: ${{ secrets.FULL_DROPBOX_TESTER_TEAM_REFRESH_TOKEN }}
21-
FULL_DROPBOX_TESTER_USER_REFRESH_TOKEN: ${{ secrets.FULL_DROPBOX_TESTER_USER_REFRESH_TOKEN }}
22-
TEAM_MEMBER_EMAIL: ${{ secrets.TEAM_MEMBER_EMAIL }}
23-
NON_TEAM_MEMBER_EMAIL: ${{ secrets.NON_TEAM_MEMBER_EMAIL }}
24-
REFRESH_TOKEN_ACCOUNT_ID: ${{ secrets.REFRESH_TOKEN_ACCOUNT_ID }}
25-
ANY_OTHER_ACCOUNT_ID: ${{ secrets.ANY_OTHER_ACCOUNT_ID }}
26-
NON_TEAM_MEMBER_ACCOUNT_ID: ${{ secrets.NON_TEAM_MEMBER_ACCOUNT_ID }}
27-
platform: ${{ 'iOS Simulator' }}
28-
device: ${{ 'iPhone 16' }}
19+
platform: 'iOS Simulator'
20+
device: 'iPhone 16'
2921
run: |
3022
xcodebuild -workspace TestObjectiveDropbox/TestObjectiveDropbox.xcworkspace/ -scheme TestObjectiveDropbox_iOS -sdk iphonesimulator \
3123
-destination "platform=$platform,name=$device" \
32-
FULL_DROPBOX_API_APP_KEY=$FULL_DROPBOX_API_APP_KEY \
33-
FULL_DROPBOX_TESTER_TEAM_REFRESH_TOKEN=$FULL_DROPBOX_TESTER_TEAM_REFRESH_TOKEN \
34-
FULL_DROPBOX_TESTER_USER_REFRESH_TOKEN=$FULL_DROPBOX_TESTER_USER_REFRESH_TOKEN \
35-
TEAM_MEMBER_EMAIL=$TEAM_MEMBER_EMAIL \
36-
NON_TEAM_MEMBER_EMAIL=$NON_TEAM_MEMBER_EMAIL \
37-
REFRESH_TOKEN_ACCOUNT_ID=$REFRESH_TOKEN_ACCOUNT_ID \
38-
ANY_OTHER_ACCOUNT_ID=$ANY_OTHER_ACCOUNT_ID \
39-
NON_TEAM_MEMBER_ACCOUNT_ID=$NON_TEAM_MEMBER_ACCOUNT_ID \
40-
test
24+
build-for-testing
4125
- name: Test macOS
4226
env:
43-
FULL_DROPBOX_API_APP_KEY: ${{ secrets.FULL_DROPBOX_API_APP_KEY }}
44-
FULL_DROPBOX_TESTER_TEAM_REFRESH_TOKEN: ${{ secrets.FULL_DROPBOX_TESTER_TEAM_REFRESH_TOKEN }}
45-
FULL_DROPBOX_TESTER_USER_REFRESH_TOKEN: ${{ secrets.FULL_DROPBOX_TESTER_USER_REFRESH_TOKEN }}
46-
TEAM_MEMBER_EMAIL: ${{ secrets.TEAM_MEMBER_EMAIL }}
47-
NON_TEAM_MEMBER_EMAIL: ${{ secrets.NON_TEAM_MEMBER_EMAIL }}
48-
REFRESH_TOKEN_ACCOUNT_ID: ${{ secrets.REFRESH_TOKEN_ACCOUNT_ID }}
49-
ANY_OTHER_ACCOUNT_ID: ${{ secrets.ANY_OTHER_ACCOUNT_ID }}
50-
NON_TEAM_MEMBER_ACCOUNT_ID: ${{ secrets.NON_TEAM_MEMBER_ACCOUNT_ID }}
51-
platform: ${{ 'macOS' }}
27+
platform: macOS
5228
run: |
5329
xcodebuild -workspace TestObjectiveDropbox/TestObjectiveDropbox.xcworkspace/ -scheme TestObjectiveDropbox_macOS \
5430
-destination "platform=$platform,arch=x86_64" \
55-
FULL_DROPBOX_API_APP_KEY=$FULL_DROPBOX_API_APP_KEY \
56-
FULL_DROPBOX_TESTER_TEAM_REFRESH_TOKEN=$FULL_DROPBOX_TESTER_TEAM_REFRESH_TOKEN \
57-
FULL_DROPBOX_TESTER_USER_REFRESH_TOKEN=$FULL_DROPBOX_TESTER_USER_REFRESH_TOKEN \
58-
TEAM_MEMBER_EMAIL=$TEAM_MEMBER_EMAIL \
59-
NON_TEAM_MEMBER_EMAIL=$NON_TEAM_MEMBER_EMAIL \
60-
REFRESH_TOKEN_ACCOUNT_ID=$REFRESH_TOKEN_ACCOUNT_ID \
61-
ANY_OTHER_ACCOUNT_ID=$ANY_OTHER_ACCOUNT_ID \
62-
NON_TEAM_MEMBER_ACCOUNT_ID=$NON_TEAM_MEMBER_ACCOUNT_ID \
63-
test
31+
build-for-testing

‎TestObjectiveDropbox/TestObjectiveDropbox.xcodeproj/xcshareddata/xcschemes/TestObjectiveDropbox_iOS.xcscheme‎

Lines changed: 0 additions & 42 deletions
Original file line numberDiff line numberDiff line change
@@ -36,48 +36,6 @@
3636
ReferencedContainer = "container:TestObjectiveDropbox.xcodeproj">
3737
</BuildableReference>
3838
</MacroExpansion>
39-
<EnvironmentVariables>
40-
<EnvironmentVariable
41-
key = "NON_TEAM_MEMBER_EMAIL"
42-
value = "$(NON_TEAM_MEMBER_EMAIL)"
43-
isEnabled = "YES">
44-
</EnvironmentVariable>
45-
<EnvironmentVariable
46-
key = "REFRESH_TOKEN_ACCOUNT_ID"
47-
value = "$(REFRESH_TOKEN_ACCOUNT_ID)"
48-
isEnabled = "YES">
49-
</EnvironmentVariable>
50-
<EnvironmentVariable
51-
key = "ANY_OTHER_ACCOUNT_ID"
52-
value = "$(ANY_OTHER_ACCOUNT_ID)"
53-
isEnabled = "YES">
54-
</EnvironmentVariable>
55-
<EnvironmentVariable
56-
key = "NON_TEAM_MEMBER_ACCOUNT_ID"
57-
value = "$(NON_TEAM_MEMBER_ACCOUNT_ID)"
58-
isEnabled = "YES">
59-
</EnvironmentVariable>
60-
<EnvironmentVariable
61-
key = "TEAM_MEMBER_EMAIL"
62-
value = "$(TEAM_MEMBER_EMAIL)"
63-
isEnabled = "YES">
64-
</EnvironmentVariable>
65-
<EnvironmentVariable
66-
key = "FULL_DROPBOX_TESTER_USER_REFRESH_TOKEN"
67-
value = "$(FULL_DROPBOX_TESTER_USER_REFRESH_TOKEN)"
68-
isEnabled = "YES">
69-
</EnvironmentVariable>
70-
<EnvironmentVariable
71-
key = "FULL_DROPBOX_TESTER_TEAM_REFRESH_TOKEN"
72-
value = "$(FULL_DROPBOX_TESTER_TEAM_REFRESH_TOKEN)"
73-
isEnabled = "YES">
74-
</EnvironmentVariable>
75-
<EnvironmentVariable
76-
key = "FULL_DROPBOX_API_APP_KEY"
77-
value = "$(FULL_DROPBOX_API_APP_KEY)"
78-
isEnabled = "YES">
79-
</EnvironmentVariable>
80-
</EnvironmentVariables>
8139
<Testables>
8240
<TestableReference
8341
skipped = "NO">

‎TestObjectiveDropbox/TestObjectiveDropbox.xcodeproj/xcshareddata/xcschemes/TestObjectiveDropbox_macOS.xcscheme‎

Lines changed: 0 additions & 42 deletions
Original file line numberDiff line numberDiff line change
@@ -36,48 +36,6 @@
3636
ReferencedContainer = "container:TestObjectiveDropbox.xcodeproj">
3737
</BuildableReference>
3838
</MacroExpansion>
39-
<EnvironmentVariables>
40-
<EnvironmentVariable
41-
key = "FULL_DROPBOX_API_APP_KEY"
42-
value = "$(FULL_DROPBOX_API_APP_KEY)"
43-
isEnabled = "YES">
44-
</EnvironmentVariable>
45-
<EnvironmentVariable
46-
key = "NON_TEAM_MEMBER_EMAIL"
47-
value = "$(NON_TEAM_MEMBER_EMAIL)"
48-
isEnabled = "YES">
49-
</EnvironmentVariable>
50-
<EnvironmentVariable
51-
key = "REFRESH_TOKEN_ACCOUNT_ID"
52-
value = "$(REFRESH_TOKEN_ACCOUNT_ID)"
53-
isEnabled = "YES">
54-
</EnvironmentVariable>
55-
<EnvironmentVariable
56-
key = "ANY_OTHER_ACCOUNT_ID"
57-
value = "$(ANY_OTHER_ACCOUNT_ID)"
58-
isEnabled = "YES">
59-
</EnvironmentVariable>
60-
<EnvironmentVariable
61-
key = "NON_TEAM_MEMBER_ACCOUNT_ID"
62-
value = "$(NON_TEAM_MEMBER_ACCOUNT_ID)"
63-
isEnabled = "YES">
64-
</EnvironmentVariable>
65-
<EnvironmentVariable
66-
key = "TEAM_MEMBER_EMAIL"
67-
value = "$(TEAM_MEMBER_EMAIL)"
68-
isEnabled = "YES">
69-
</EnvironmentVariable>
70-
<EnvironmentVariable
71-
key = "FULL_DROPBOX_TESTER_TEAM_REFRESH_TOKEN"
72-
value = "$(FULL_DROPBOX_TESTER_TEAM_REFRESH_TOKEN)"
73-
isEnabled = "YES">
74-
</EnvironmentVariable>
75-
<EnvironmentVariable
76-
key = "FULL_DROPBOX_TESTER_USER_REFRESH_TOKEN"
77-
value = "$(FULL_DROPBOX_TESTER_USER_REFRESH_TOKEN)"
78-
isEnabled = "YES">
79-
</EnvironmentVariable>
80-
</EnvironmentVariables>
8139
<Testables>
8240
<TestableReference
8341
skipped = "NO">

0 commit comments

Comments
 (0)