Add ability to attach library stylesheets and/or scripts#8
Open
waako wants to merge 2 commits intodrupal-pattern-lab:masterfrom
Open
Add ability to attach library stylesheets and/or scripts#8waako wants to merge 2 commits intodrupal-pattern-lab:masterfrom
waako wants to merge 2 commits intodrupal-pattern-lab:masterfrom
Conversation
Add missing spaces. Keep array syntax consistent and short.
If CSS files, create merged array of files for each group (base, theme). Then for each CSS file create link stylesheet. Wrap foreach js files in if statement so library can contain JS or CSS.
Author
|
@georgebrook in what way is it not working, not loading css/js assets defined in If I recall, have to use To be honest, a better solution for that part is Pr #11 use of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes it possible to attach local or external css files even if in multiple groups.
Library file like this should work in all instances: