Merge branch 'main' into copilot/fix-2e4f4524-bcfc-418f-abb1-7eb2a7482232

Author: johlju

.github/copilot-instructions.md

@@ -1,35 +1,2 @@
-# AI Instructions
-
-This file provides AI agent guidance for the project. Each instruction file below
-targets specific file glob patterns and use cases.
-
-## Build & Test Workflow
-- Run in PowerShell, from repository root
-- Build before running tests: `.\build.ps1 -Tasks build`
-- Always run tests in new PowerShell session: `Invoke-Pester -Path @({test paths}) -Output Detailed`
-
-## Instructions Overview
-
-The guidelines always take priority over existing code patterns in project.
-
+# Requirements
 - SqlServerDsc-specific guidelines override general project guidelines
-- Follow PowerShell style guidelines
-- Maintain localization requirements across all source files
-- Follow test patterns strictly for maintainability
-
-## Core Project Guidelines
-
-- Follow SqlServerDsc project specific guidelines: [./instructions/SqlServerDsc-guidelines.instructions.md](./instructions/SqlServerDsc-guidelines.instructions.md)
-- Always follow PowerShell code style guidelines: [./instructions/dsc-community-style-guidelines-powershell.instructions.md](./instructions/dsc-community-style-guidelines-powershell.instructions.md)
-- Follow Project-level guidelines: [./instructions/dsc-community-style-guidelines.instructions.md](./instructions/dsc-community-style-guidelines.instructions.md)
-- Follow localization requirements: [./instructions/dsc-community-style-guidelines-localization.instructions.md](./instructions/dsc-community-style-guidelines-localization.instructions.md)
-- Always add Unit testing according to: [./instructions/dsc-community-style-guidelines-unit-tests.instructions.md](./instructions/dsc-community-style-guidelines-unit-tests.instructions.md)
-- Always add Integration testing according to: [./instructions/dsc-community-style-guidelines-integration-tests.instructions.md](./instructions/dsc-community-style-guidelines-integration-tests.instructions.md)
-- Follow Markdown formatting requirements: [./instructions/dsc-community-style-guidelines-markdown.instructions.md](./instructions/dsc-community-style-guidelines-markdown.instructions.md)
-- Always update CHANGELOG.md: [./instructions/dsc-community-style-guidelines-changelog.instructions.md](./instructions/dsc-community-style-guidelines-changelog.instructions.md)
-
-## Desired State Configuration (DSC) Resource Guidelines
-
-New DSC resources should always be created as class-based resources.
-
-- Follow class-based resources guidelines: [./instructions/dsc-community-style-guidelines-class-resource.instructions.md](./instructions/dsc-community-style-guidelines-class-resource.instructions.md)

.github/instructions/dsc-community-style-guidelines-class-resource.instructions.md

@@ -86,9 +86,9 @@ Add to .DESCRIPTION section:
 - `## Requirements`: List minimum requirements
 - `## Known issues`: Critical issues + pattern: `All issues are not listed here, see [all open issues](https://github.com/{owner}/{repo}/issues?q=is%3Aissue+is%3Aopen+in%3Atitle+{ResourceName}).`
 
-## Error Handling
+## Error Handling for classes
 - Use `try/catch` blocks to handle exceptions
-- Do not use `throw` for terminating errors, use `New-*Exception` commands:
+- Do not use `throw` for terminating errors, use `New-*Exception` commands (never for functions):
   - [`New‑InvalidDataException`](https://github.com/dsccommunity/DscResource.Common/wiki/New%E2%80%91InvalidDataException)
   - [`New-ArgumentException`](https://github.com/dsccommunity/DscResource.Common/wiki/New%E2%80%91ArgumentException)
   - [`New-InvalidOperationException`](https://github.com/dsccommunity/DscResource.Common/wiki/New%E2%80%91InvalidOperationException)

.github/instructions/dsc-community-style-guidelines-mof-resources.instructions.md

@@ -28,10 +28,9 @@ applyTo: "source/DSCResources/**/*.psm1"
 - Use localized strings for all messages (Write-Verbose, Write-Error, etc.)
 - Import localized strings using `Get-LocalizedData` at module top
 
-## Error Handling
-- Do not use `throw` for terminating errors
+## Error Handling for MOF-based resources
 - Use `try/catch` blocks to handle exceptions
-- Throw localized exceptions using the appropriate `New-*Exception` cmdlet:
+- Do not use `throw` for terminating errors, use `New-*Exception` commands (never for functions):
   - [`New‑InvalidDataException`](https://github.com/dsccommunity/DscResource.Common/wiki/New%E2%80%91InvalidDataException)
   - [`New-ArgumentException`](https://github.com/dsccommunity/DscResource.Common/wiki/New%E2%80%91ArgumentException)
   - [`New-InvalidOperationException`](https://github.com/dsccommunity/DscResource.Common/wiki/New%E2%80%91InvalidOperationException)

.github/instructions/dsc-community-style-guidelines-pester.instructions.md

@@ -14,6 +14,13 @@ applyTo: "**/*.[Tt]ests.ps1"
 - Never test verbose messages, debug messages or parameter binding behavior
 - Pass all mandatory parameters to avoid prompts
 
+## Requirements
+- Inside `It` blocks, assign unused return objects to `$null` (unless part of pipeline)
+- Tested entity must be called from within the `It` blocks
+- Keep results and assertions in same `It` block
+- Avoid try-catch-finally for cleanup, use `AfterAll` or `AfterEach`
+- Avoid unnecessary remove/recreate cycles
+
 ## Naming
 - One `Describe` block per file matching the tested entity name
 - `Context` descriptions start with 'When'
@@ -51,10 +58,6 @@ applyTo: "**/*.[Tt]ests.ps1"
 - Keep scope close to usage context
 
 ## Best Practices
-- Inside `It` blocks, assign unused return objects to `$null` (unless part of pipeline)
-- Tested entity must be called from within the `It` blocks
-- Keep results and assertions in same `It` block
 - Cover all scenarios and code paths
 - Use `BeforeEach` and `AfterEach` sparingly
-- Avoid try-catch-finally for cleanup, use `AfterAll` or `AfterEach`
-- Avoid unnecessary remove/recreate cycles
+- Use `$PSDefaultParameterValues` only for Pester commands (`Describe`, `Context`, `It`, `Mock`, `Should`, `InModuleScope`)

.github/instructions/dsc-community-style-guidelines-powershell.instructions.md

@@ -79,7 +79,9 @@ applyTo: "**/*.ps?(m|d)1"
 - For state-changing functions, use `SupportsShouldProcess`
   - Place ShouldProcess check immediately before each state-change
   - `$PSCmdlet.ShouldProcess` must use required pattern
+  - Inside `$PSCmdlet.ShouldProcess`-block, avoid using `Write-Verbose`
 - Never use backtick as line continuation in production code.
+- Set `$ErrorActionPreference = 'Stop'` before commands using `-ErrorAction 'Stop'`; restore after
 
 ## Output streams
 
@@ -88,7 +90,7 @@ applyTo: "**/*.ps?(m|d)1"
 - Use `Write-Verbose` for: High-level execution flow only; User-actionable information
 - Use `Write-Information` for: User-facing status updates; Important operational messages; Non-error state changes
 - Use `Write-Warning` for: Non-fatal issues requiring attention; Deprecated functionality usage; Configuration problems that don't block execution
-- Use `$PSCmdlet.ThrowTerminatingError()` for terminating errors (except for classes), use relevant error category
+- Use `$PSCmdlet.ThrowTerminatingError()` for terminating errors (except for classes), use relevant error category, in try-catch include exception
 - Use `Write-Error` for non-terminating errors, use relevant error category
 
 ## ShouldProcess Required Pattern
@@ -181,6 +183,7 @@ function Get-Something
 - Limit piping to one pipe per line
 - Assign function results to variables rather than inline calls
 - Return a single, consistent object type per function
+  - return `$null` for no objects/non-terminating errors
 
 ### Security & Safety
 

.github/instructions/dsc-community-style-guidelines.instructions.md

@@ -22,10 +22,12 @@ applyTo: "**"
 - Integration tests: `tests/Integration/Commands/{CommandName}.Integration.Tests.ps1`
 
 ## Requirements
-- Follow guidelines over existing code patterns
+- Follow instructions over existing code patterns
+- Follow PowerShell style and test guideline instructions strictly
 - Always update CHANGELOG.md Unreleased section
 - Localize all strings using string keys; remove any orphaned string keys
 - Check DscResource.Common before creating private functions
 - Separate reusable logic into private functions
+- DSC resources should always be created as class-based resources
 - Add unit tests for all commands/functions/resources
 - Add integration tests for all public commands and resources

.github/workflows/code-analysis-built-module.yml

@@ -25,7 +25,6 @@ jobs:
         shell: powershell
         run: |
           dotnet tool install --global GitVersion.Tool --version 5.*
-          dotnet-gitversion
       - name: Run GitVersion
         shell: powershell
         run: |

.github/workflows/code-analysis.yml

@@ -25,7 +25,6 @@ jobs:
         shell: powershell
         run: |
           dotnet tool install --global GitVersion.Tool --version 5.*
-          dotnet-gitversion
       - name: Run GitVersion
         shell: powershell
         run: |

.github/workflows/copilot-setup-steps.yml

@@ -205,8 +205,6 @@ jobs:
       - name: Verify GitVersion
         shell: pwsh
         run: |
-          Write-Host 'Running GitVersion to determine semantic version...'
-          dotnet-gitversion
           Write-Host 'Running GitVersion to determine semantic version (parsing to PowerShell object)...'
           dotnet-gitversion | ConvertFrom-Json
 

.vscode/settings.json

@@ -90,7 +90,8 @@
         "SOURCEBRANCH",
         "SOURCEBRANCHNAME",
         "setvariable",
-        "RAISERROR"
+        "RAISERROR",
+        "filegroup"
     ],
     "cSpell.ignorePaths": [
         ".git"