Update Get-SqlDscRSDatabaseInstallation tests to handle GUIDs without braces

Author: johlju

tests/Integration/Commands/Get-SqlDscRSDatabaseInstallation.Integration.Tests.ps1

@@ -36,7 +36,8 @@ Describe 'Get-SqlDscRSDatabaseInstallation' {
         BeforeAll {
             $script:expectedMachineName = Get-ComputerName
             $script:configuration = Get-SqlDscRSConfiguration -InstanceName 'SSRS' -ErrorAction 'Stop'
-            $script:expectedInstallationID = $script:configuration.InstallationID
+            # Strip braces as Get-SqlDscRSDatabaseInstallation returns IDs without braces
+            $script:expectedInstallationID = $script:configuration.InstallationID -replace '[{}]'
         }
 
         It 'Should return database installation information' {
@@ -61,7 +62,8 @@ Describe 'Get-SqlDscRSDatabaseInstallation' {
         BeforeAll {
             $script:expectedMachineName = Get-ComputerName
             $script:configuration = Get-SqlDscRSConfiguration -InstanceName 'SSRS' -ErrorAction 'Stop'
-            $script:expectedInstallationID = $script:configuration.InstallationID
+            # Strip braces as Get-SqlDscRSDatabaseInstallation returns IDs without braces
+            $script:expectedInstallationID = $script:configuration.InstallationID -replace '[{}]'
         }
 
         It 'Should return database installation information' {
@@ -86,7 +88,8 @@ Describe 'Get-SqlDscRSDatabaseInstallation' {
         BeforeAll {
             $script:expectedMachineName = Get-ComputerName
             $script:configuration = Get-SqlDscRSConfiguration -InstanceName 'SSRS' -ErrorAction 'Stop'
-            $script:expectedInstallationID = $script:configuration.InstallationID
+            # Strip braces as Get-SqlDscRSDatabaseInstallation returns IDs without braces
+            $script:expectedInstallationID = $script:configuration.InstallationID -replace '[{}]'
         }
 
         It 'Should return database installation information' {
@@ -111,7 +114,8 @@ Describe 'Get-SqlDscRSDatabaseInstallation' {
         BeforeAll {
             $script:expectedMachineName = Get-ComputerName
             $script:configuration = Get-SqlDscRSConfiguration -InstanceName 'PBIRS' -ErrorAction 'Stop'
-            $script:expectedInstallationID = $script:configuration.InstallationID
+            # Strip braces as Get-SqlDscRSDatabaseInstallation returns IDs without braces
+            $script:expectedInstallationID = $script:configuration.InstallationID -replace '[{}]'
         }
 
         It 'Should return database installation information' {

tests/Unit/Public/Get-SqlDscRSDatabaseInstallation.Tests.ps1

@@ -69,26 +69,28 @@ Describe 'Get-SqlDscRSDatabaseInstallation' {
                 InstanceName = 'SSRS'
             }
 
+            # The CIM method returns GUIDs without braces
             Mock -CommandName Invoke-RsCimMethod -MockWith {
                 return @{
-                    Length         = 2
-                    InstallationIDs = @('GUID1', 'GUID2')
+                    Length          = 2
+                    InstallationIDs = @('c59fadae-f8ee-46ee-b063-f8d89872100c', 'a1b2c3d4-e5f6-7890-abcd-ef1234567890')
                     MachineNames    = @('SERVER1', 'SERVER2')
                     InstanceNames   = @('SSRS', 'SSRS')
                     IsInitialized   = @($true, $true)
                 }
             }
         }
 
-        It 'Should return installation objects' {
+        It 'Should return installation objects with GUIDs without braces' {
             $result = $mockCimInstance | Get-SqlDscRSDatabaseInstallation
 
             $result | Should -Not -BeNullOrEmpty
             $result | Should -HaveCount 2
-            $result[0].InstallationID | Should -Be 'GUID1'
+            $result[0].InstallationID | Should -Be 'c59fadae-f8ee-46ee-b063-f8d89872100c'
             $result[0].MachineName | Should -Be 'SERVER1'
             $result[0].InstanceName | Should -Be 'SSRS'
             $result[0].IsInitialized | Should -BeTrue
+            $result[1].InstallationID | Should -Be 'a1b2c3d4-e5f6-7890-abcd-ef1234567890'
 
             Should -Invoke -CommandName Invoke-RsCimMethod -ParameterFilter {
                 $MethodName -eq 'ListReportServersInDatabase'
@@ -144,10 +146,11 @@ Describe 'Get-SqlDscRSDatabaseInstallation' {
                 InstanceName = 'SSRS'
             }
 
+            # The CIM method returns GUIDs without braces
             Mock -CommandName Invoke-RsCimMethod -MockWith {
                 return @{
                     Length          = 1
-                    InstallationIDs = @('GUID1')
+                    InstallationIDs = @('d4e5f6a7-b8c9-0123-4567-890abcdef012')
                     MachineNames    = @('SERVER1')
                     InstanceNames   = @('SSRS')
                     IsInitialized   = @($true)
@@ -160,6 +163,7 @@ Describe 'Get-SqlDscRSDatabaseInstallation' {
 
             $result | Should -Not -BeNullOrEmpty
             $result | Should -HaveCount 1
+            $result.InstallationID | Should -Be 'd4e5f6a7-b8c9-0123-4567-890abcdef012'
 
             Should -Invoke -CommandName Invoke-RsCimMethod -Exactly -Times 1
         }