Skip to content

Commit 527dcd4

Browse files
authored
SqlWindowsFirewall: Avoid Duplication of SQL Server Browser Firewall Rule (#1944)
- SqlWindowsFirewall - Fix duplication of SQL Server Browser Firewall Rule when deploying Analysis Services feature (issue #1942).
1 parent f9bde8a commit 527dcd4

File tree

2 files changed

+5
-0
lines changed

2 files changed

+5
-0
lines changed

CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
2727
- `Import-SqlDscPreferredModule`
2828
- Now when parameter `Force` is passed the command correctly invoke
2929
`Get-SqlDscPreferredModule` using the parameter `Refresh`.
30+
- SqlWindowsFirewall
31+
- Fix duplication of SQL Server Browser Firewall Rule when deploying
32+
Analysis Services feature ([issue #1942](https://github.com/dsccommunity/SqlServerDsc/issues/1942)).
3033

3134
## [16.3.1] - 2023-05-06
3235

source/DSCResources/DSC_SqlWindowsFirewall/DSC_SqlWindowsFirewall.psm1

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -475,6 +475,7 @@ function Set-TargetResource
475475
}
476476

477477
New-NetFirewallRule @browserFirewallRuleParameters
478+
$getTargetResourceResult.BrowserFirewall = $true
478479
}
479480
}
480481

@@ -544,6 +545,7 @@ function Set-TargetResource
544545
}
545546

546547
New-NetFirewallRule @browserFirewallRuleParameters
548+
$getTargetResourceResult.BrowserFirewall = $true
547549
}
548550
}
549551

0 commit comments

Comments
 (0)