Skip to content

Remove Get-RegistryPropertyValue function#2076

Merged
johlju merged 1 commit intodsccommunity:mainfrom
johlju:fix/use-common-getregistrypropertyvalue
Mar 11, 2025
Merged

Remove Get-RegistryPropertyValue function#2076
johlju merged 1 commit intodsccommunity:mainfrom
johlju:fix/use-common-getregistrypropertyvalue

Conversation

@johlju
Copy link
Copy Markdown
Member

@johlju johlju commented Mar 10, 2025

Pull Request (PR) description

  • SqlServerDsc.Common
    • Removed the function Get-RegistryPropertyValue in favor of the command
      with the same name in the module DscResource.Common.

This Pull Request (PR) fixes the following issues

None.

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Resource documentation updated in the resource's README.md.
  • Resource parameter descriptions updated in schema.mof.
  • Comment-based help updated, including parameter descriptions.
  • Localization strings updated.
  • Examples updated.
  • Unit tests updated. See DSC Community Testing Guidelines.
  • Integration tests updated (where possible). See DSC Community Testing Guidelines.
  • Code changes adheres to DSC Community Style Guidelines.

This change is Reviewable

@johlju johlju requested a review from a team as a code owner March 10, 2025 23:19
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94%. Comparing base (17a73d9) to head (3a665ad).
Report is 20 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@         Coverage Diff          @@
##           main   #2076   +/-   ##
====================================
- Coverage    94%     94%   -1%     
====================================
  Files       101     101           
  Lines      8004    7998    -6     
====================================
- Hits       7577    7571    -6     
  Misses      427     427           
Flag Coverage Δ
unit ∅ <ø> (∅)
Files with missing lines Coverage Δ
...dules/SqlServerDsc.Common/SqlServerDsc.Common.psm1 96% <ø> (-1%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Member Author

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @johlju)

@johlju johlju merged commit ed70887 into dsccommunity:main Mar 11, 2025
52 checks passed
@johlju johlju deleted the fix/use-common-getregistrypropertyvalue branch March 11, 2025 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant