Skip to content

SQLRS Enable Integration Tests#2095

Merged
johlju merged 14 commits intodsccommunity:mainfrom
dan-hughes:issue-2009
Apr 22, 2025
Merged

SQLRS Enable Integration Tests#2095
johlju merged 14 commits intodsccommunity:mainfrom
dan-hughes:issue-2009

Conversation

@dan-hughes
Copy link
Copy Markdown
Contributor

@dan-hughes dan-hughes commented Apr 16, 2025

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Resource documentation updated in the resource's README.md.
  • Resource parameter descriptions updated in schema.mof.
  • Comment-based help updated, including parameter descriptions.
  • Localization strings updated.
  • Examples updated.
  • Unit tests updated. See DSC Community Testing Guidelines.
  • Integration tests updated (where possible). See DSC Community Testing Guidelines.
  • Code changes adheres to DSC Community Style Guidelines.

This change is Reviewable

@dan-hughes
Copy link
Copy Markdown
Contributor Author

@johlju,

Seems like RS tests are okay now.

I also looked at the SQL/OS compatibility matrix and matched up the pipeline matrixes to suit. Makes more tests but covers what's 'supported'.

@johlju johlju requested a review from Copilot April 20, 2025 14:02
@johlju johlju added the needs review The pull request needs a code review. label Apr 20, 2025
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR re-enables integration tests for SQLRS by updating the Azure Pipelines configuration and adjusting the test matrices.

  • Updated vmImage values in the azure-pipelines.yml file (e.g., changing from windows-2019/windows-2022 to include windows-2025).
  • Revised the integration test job definitions and matrix configurations to reflect the new target environments.
  • Updated the CHANGELOG.md to document the re-enabling of integration tests.

Reviewed Changes

Copilot reviewed 2 out of 5 changed files in this pull request and generated no comments.

File Description
azure-pipelines.yml Updated test matrices and vmImage values to support integration tests.
CHANGELOG.md Updated changelog entry to reflect the re-enablement of integration tests.
Files not reviewed (3)
  • tests/Integration/Resources/DSC_SqlRS.Integration.Tests.ps1: Language not supported
  • tests/Integration/Resources/DSC_SqlRS_Default.Integration.Tests.ps1: Language not supported
  • tests/Unit/DSC_SqlSetup.Tests.ps1: Language not supported
Comments suppressed due to low confidence (1)

azure-pipelines.yml:219

  • Verify that 'windows-2025' is a valid Azure Pipelines image for integration tests, as it deviates from the usual image naming convention.
SQL2019_WIN2025:

Copy link
Copy Markdown
Member

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @dan-hughes)


azure-pipelines.yml line 364 at r1 (raw file):

        strategy:
          matrix:
            SQL2022_WIN2019:

Can we change this to PowerBI_WIN2019. It will then be the same as PR https://github.com/dsccommunity/SqlServerDsc/pull/2083/files#diff-7915b9b726a397ae7ba6af7b9703633d21c031ebf21682f3ee7e6a4ec52837a5 proposes.

Suggestion:

PowerBI_WIN2019

azure-pipelines.yml line 367 at r1 (raw file):

              JOB_VMIMAGE: 'windows-2019'
              TEST_CONFIGURATION: 'Integration_PowerBI'
            SQL2022_WIN2022:

Can we change this to PowerBI_WIN2022.

Suggestion:

PowerBI_WIN2022

azure-pipelines.yml line 370 at r1 (raw file):

              JOB_VMIMAGE: 'windows-2022'
              TEST_CONFIGURATION: 'Integration_PowerBI'
            SQL2022_WIN2025:

Can we change this to PowerBI_WIN2025.

@dan-hughes
Copy link
Copy Markdown
Contributor Author

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @dan-hughes)

azure-pipelines.yml line 364 at r1 (raw file):

        strategy:
          matrix:
            SQL2022_WIN2019:

Can we change this to PowerBI_WIN2019. It will then be the same as PR https://github.com/dsccommunity/SqlServerDsc/pull/2083/files#diff-7915b9b726a397ae7ba6af7b9703633d21c031ebf21682f3ee7e6a4ec52837a5 proposes.

Suggestion:

PowerBI_WIN2019

azure-pipelines.yml line 367 at r1 (raw file):

              JOB_VMIMAGE: 'windows-2019'
              TEST_CONFIGURATION: 'Integration_PowerBI'
            SQL2022_WIN2022:

Can we change this to PowerBI_WIN2022.

Suggestion:

PowerBI_WIN2022

azure-pipelines.yml line 370 at r1 (raw file):

              JOB_VMIMAGE: 'windows-2022'
              TEST_CONFIGURATION: 'Integration_PowerBI'
            SQL2022_WIN2025:

Can we change this to PowerBI_WIN2025.

These look to define the job name. Do they want to be pretty and look good on Azure DevOps?

Copy link
Copy Markdown
Member

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @dan-hughes)


azure-pipelines.yml line 370 at r1 (raw file):

Previously, dan-hughes (Daniel Hughes) wrote…

These look to define the job name. Do they want to be pretty and look good on Azure DevOps?

More that the job is actually testing PowerBI, not SQL. It was a copy paste mistake to begin with. 🙂

Just thought fixing these three here it would make me not miss fixing the new one in the other PR. 🙂

@dan-hughes dan-hughes marked this pull request as ready for review April 20, 2025 16:37
@dan-hughes dan-hughes requested a review from a team as a code owner April 20, 2025 16:37
Copy link
Copy Markdown
Member

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dan-hughes)

@johlju johlju merged commit 012ea6b into dsccommunity:main Apr 22, 2025
56 checks passed
@johlju johlju removed the needs review The pull request needs a code review. label Apr 22, 2025
@dan-hughes dan-hughes deleted the issue-2009 branch April 22, 2025 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add pipeline jobs for Windows Server 2025 SqlRs: Integration test fails on SQL Server 2022

3 participants