SQLRS Enable Integration Tests#2095
Conversation
|
Seems like RS tests are okay now. I also looked at the SQL/OS compatibility matrix and matched up the pipeline matrixes to suit. Makes more tests but covers what's 'supported'. |
There was a problem hiding this comment.
Pull Request Overview
This PR re-enables integration tests for SQLRS by updating the Azure Pipelines configuration and adjusting the test matrices.
- Updated vmImage values in the azure-pipelines.yml file (e.g., changing from windows-2019/windows-2022 to include windows-2025).
- Revised the integration test job definitions and matrix configurations to reflect the new target environments.
- Updated the CHANGELOG.md to document the re-enabling of integration tests.
Reviewed Changes
Copilot reviewed 2 out of 5 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| azure-pipelines.yml | Updated test matrices and vmImage values to support integration tests. |
| CHANGELOG.md | Updated changelog entry to reflect the re-enablement of integration tests. |
Files not reviewed (3)
- tests/Integration/Resources/DSC_SqlRS.Integration.Tests.ps1: Language not supported
- tests/Integration/Resources/DSC_SqlRS_Default.Integration.Tests.ps1: Language not supported
- tests/Unit/DSC_SqlSetup.Tests.ps1: Language not supported
Comments suppressed due to low confidence (1)
azure-pipelines.yml:219
- Verify that 'windows-2025' is a valid Azure Pipelines image for integration tests, as it deviates from the usual image naming convention.
SQL2019_WIN2025:
johlju
left a comment
There was a problem hiding this comment.
Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @dan-hughes)
azure-pipelines.yml line 364 at r1 (raw file):
strategy: matrix: SQL2022_WIN2019:
Can we change this to PowerBI_WIN2019. It will then be the same as PR https://github.com/dsccommunity/SqlServerDsc/pull/2083/files#diff-7915b9b726a397ae7ba6af7b9703633d21c031ebf21682f3ee7e6a4ec52837a5 proposes.
Suggestion:
PowerBI_WIN2019azure-pipelines.yml line 367 at r1 (raw file):
JOB_VMIMAGE: 'windows-2019' TEST_CONFIGURATION: 'Integration_PowerBI' SQL2022_WIN2022:
Can we change this to PowerBI_WIN2022.
Suggestion:
PowerBI_WIN2022azure-pipelines.yml line 370 at r1 (raw file):
JOB_VMIMAGE: 'windows-2022' TEST_CONFIGURATION: 'Integration_PowerBI' SQL2022_WIN2025:
Can we change this to PowerBI_WIN2025.
These look to define the job name. Do they want to be pretty and look good on Azure DevOps? |
johlju
left a comment
There was a problem hiding this comment.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @dan-hughes)
azure-pipelines.yml line 370 at r1 (raw file):
Previously, dan-hughes (Daniel Hughes) wrote…
These look to define the job name. Do they want to be pretty and look good on Azure DevOps?
More that the job is actually testing PowerBI, not SQL. It was a copy paste mistake to begin with. 🙂
Just thought fixing these three here it would make me not miss fixing the new one in the other PR. 🙂
johlju
left a comment
There was a problem hiding this comment.
Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @dan-hughes)
Pull Request (PR) description
This Pull Request (PR) fixes the following issues
Task list
file CHANGELOG.md. Entry should say what was changed and how that
affects users (if applicable), and reference the issue being resolved
(if applicable).
This change is