Skip to content

SqlServerDsc: Revert ModuleBuilder workaround#2096

Merged
johlju merged 1 commit intodsccommunity:mainfrom
johlju:fix/revert-modulebuilder-workaround
Apr 21, 2025
Merged

SqlServerDsc: Revert ModuleBuilder workaround#2096
johlju merged 1 commit intodsccommunity:mainfrom
johlju:fix/revert-modulebuilder-workaround

Conversation

@johlju
Copy link
Copy Markdown
Member

@johlju johlju commented Apr 20, 2025

Pull Request (PR) description

  • SqlServerDsc
    • Revert workaround in GitHub Actions workflows as new version of ModuleBuilder
      was released.

This Pull Request (PR) fixes the following issues

None.

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Resource documentation updated in the resource's README.md.
  • Resource parameter descriptions updated in schema.mof.
  • Comment-based help updated, including parameter descriptions.
  • Localization strings updated.
  • Examples updated.
  • Unit tests updated. See DSC Community Testing Guidelines.
  • Integration tests updated (where possible). See DSC Community Testing Guidelines.
  • Code changes adheres to DSC Community Style Guidelines.

This change is Reviewable

@johlju johlju requested a review from a team as a code owner April 20, 2025 14:22
@johlju johlju requested review from Copilot and removed request for a team April 20, 2025 14:23
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR reverts the previously applied workaround in GitHub Actions workflows for ModuleBuilder now that a new version has been released. Key changes include:

  • Updating the CHANGELOG.md with an entry to note the revert.
  • Removing the "Patch ModuleBuilder" steps from both .github/workflows/code-analysis.yml and .github/workflows/code-analysis-built-module.yml.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
CHANGELOG.md Added entry to document the revert of the ModuleBuilder workaround.
.github/workflows/code-analysis.yml Removed the workaround block related to patching ModuleBuilder.
.github/workflows/code-analysis-built-module.yml Removed the workaround block related to patching ModuleBuilder.

@johlju johlju added the needs review The pull request needs a code review. label Apr 20, 2025
Copy link
Copy Markdown
Contributor

@dan-hughes dan-hughes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @johlju)

@johlju johlju merged commit b2d16b6 into dsccommunity:main Apr 21, 2025
50 checks passed
@johlju johlju deleted the fix/revert-modulebuilder-workaround branch April 21, 2025 17:08
@johlju johlju removed the needs review The pull request needs a code review. label Apr 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants