SqlServerDsc: Revert ModuleBuilder workaround#2096
Merged
johlju merged 1 commit intodsccommunity:mainfrom Apr 21, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR reverts the previously applied workaround in GitHub Actions workflows for ModuleBuilder now that a new version has been released. Key changes include:
- Updating the CHANGELOG.md with an entry to note the revert.
- Removing the "Patch ModuleBuilder" steps from both .github/workflows/code-analysis.yml and .github/workflows/code-analysis-built-module.yml.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| CHANGELOG.md | Added entry to document the revert of the ModuleBuilder workaround. |
| .github/workflows/code-analysis.yml | Removed the workaround block related to patching ModuleBuilder. |
| .github/workflows/code-analysis-built-module.yml | Removed the workaround block related to patching ModuleBuilder. |
dan-hughes
reviewed
Apr 20, 2025
Contributor
dan-hughes
left a comment
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @johlju)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
was released.
This Pull Request (PR) fixes the following issues
None.
Task list
file CHANGELOG.md. Entry should say what was changed and how that
affects users (if applicable), and reference the issue being resolved
(if applicable).
This change is