Skip to content

SqlServerDsc: Remove Test-PendingRestart function#2098

Merged
johlju merged 1 commit intodsccommunity:mainfrom
johlju:f/change-TestPendingRestart
Apr 26, 2025
Merged

SqlServerDsc: Remove Test-PendingRestart function#2098
johlju merged 1 commit intodsccommunity:mainfrom
johlju:f/change-TestPendingRestart

Conversation

@johlju
Copy link
Copy Markdown
Member

@johlju johlju commented Apr 25, 2025

Pull Request (PR) description

  • SqlServerDsc.Common
    • Removed the function Test-PendingRestart in favor of the commands with the same names in
      the module DscResource.Common.

This Pull Request (PR) fixes the following issues

None.

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Resource documentation updated in the resource's README.md.
  • Resource parameter descriptions updated in schema.mof.
  • Comment-based help updated, including parameter descriptions.
  • Localization strings updated.
  • Examples updated.
  • Unit tests updated. See DSC Community Testing Guidelines.
  • Integration tests updated (where possible). See DSC Community Testing Guidelines.
  • Code changes adheres to DSC Community Style Guidelines.

This change is Reviewable

@johlju johlju requested a review from a team as a code owner April 25, 2025 19:30
@johlju johlju added the needs review The pull request needs a code review. label Apr 25, 2025
Copy link
Copy Markdown
Member Author

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 8 of 8 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @johlju)

@johlju johlju merged commit 83c8385 into dsccommunity:main Apr 26, 2025
56 checks passed
@johlju johlju deleted the f/change-TestPendingRestart branch April 26, 2025 08:52
@johlju johlju removed the needs review The pull request needs a code review. label Apr 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant