Remove Uninstall parameter documentation from Install-SqlDscServer#2398
Merged
Remove Uninstall parameter documentation from Install-SqlDscServer#2398
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
Co-authored-by: johlju <7189721+johlju@users.noreply.github.com>
johlju
approved these changes
Jan 4, 2026
Member
johlju
left a comment
There was a problem hiding this comment.
@johlju reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @copilot[bot]).
Copilot
AI
changed the title
[WIP] Remove uninstall parameter from Install-SqlDscServer command
Remove Uninstall parameter documentation from Install-SqlDscServer
Jan 4, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2398 +/- ##
=====================================
Coverage 94% 94%
=====================================
Files 186 186
Lines 10238 10238
=====================================
Hits 9633 9633
Misses 605 605
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Install-SqlDscServercommand documented anUninstallparameter in its comment-based help that doesn't exist in the actual parameter block. This creates confusion since uninstall operations should use the dedicatedUninstall-SqlDscServercommand.Changes
.PARAMETER Uninstalldocumentation fromInstall-SqlDscServer.ps1comment-based helpThe command never accepted an
Uninstallparameter—only the internalInvoke-SetupActionfunction does. Documentation now accurately reflects the public API surface.Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.
This change is