Skip to content

Add integration tests for SqlDatabase with PsDscRunAsCredential support#2434

Closed
johlju wants to merge 4 commits intodsccommunity:mainfrom
johlju:f/add-dscv3-test-with-psdscrunascredential
Closed

Add integration tests for SqlDatabase with PsDscRunAsCredential support#2434
johlju wants to merge 4 commits intodsccommunity:mainfrom
johlju:f/add-dscv3-test-with-psdscrunascredential

Conversation

@johlju
Copy link
Copy Markdown
Member

@johlju johlju commented Jan 23, 2026

Pull Request (PR) description

  • SqlServerDsc
    • Added integration tests for SqlDatabase that exercise PsDscRunAsCredential
      and dsc config usage with a separate parameters file for secure credentials.

This Pull Request (PR) fixes the following issues

None.

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Resource documentation updated in the resource's README.md.
  • Resource parameter descriptions updated in schema.mof.
  • Comment-based help updated, including parameter descriptions.
  • Localization strings updated.
  • Examples updated.
  • Unit tests updated. See DSC Community Testing Guidelines.
  • Integration tests updated (where possible). See DSC Community Testing Guidelines.
  • Code changes adheres to DSC Community Style Guidelines.

This change is Reviewable

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jan 23, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94%. Comparing base (e971dc1) to head (6fd7f40).

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2434   +/-   ##
=====================================
  Coverage     94%     94%           
=====================================
  Files        225     225           
  Lines      10761   10761           
=====================================
  Hits       10141   10141           
  Misses       620     620           
Flag Coverage Δ
unit 94% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@johlju
Copy link
Copy Markdown
Member Author

johlju commented Jan 24, 2026

This is still not supported by DSCv3. Closing for now, reopen when DSCv3 evolved to support it.

@johlju johlju closed this Jan 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant